summer->winter time changeover looks bad on the graph

[patrickhafner]

📑 I have found these related issues/pull requests

No.

🛡️ Security Policy

• I agree to have read this project Security Policy

Description

After time changeover a few mins ago, kuma mess up the graph.

👟 Reproduction steps

Check your uptime kuma, if you are affected of time changeover from 3am MESZ to 2am again because of change to eu MEZ.

👀 Expected behavior

Rewrite graph, maybe delete the first 2AM hour?

😓 Actual Behavior

see screenshot

🐻 Uptime-Kuma Version

1.23.15

💻 Operating System and Arch

ubuntu 22.04 docker

🌐 Browser

FF latest

🖥️ Deployment Environment

• Runtime: docker (louislam/uptime-kuma:1)
• Database: sqlite
• Filesystem used to store the database on: 1
• number of monitors: 1

📝 Relevant log output

No response

[patrickhafner]

Is this a real bug? I'd love that the community and contributors think about it, because with this change we'll lose a hour of tracking. Otherwise we should extend the graph to show 2am to 3am twice to keep all data.

Looking forward to your input!

[CommanderStorm]

"Currently" (see #4500) this looks like this

• Feat: Use UptimeCalculator for PingChart #4264

Since we don't have a testcase for this, I don't know what the v2.0 system does in this case.

=> what I think is more reasonable is to deal with this at the source and just have a gap for moving foreward and logging twice in the same graph.