Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group as tag in Prometheus #5147

Closed
mgoeppl opened this issue Oct 1, 2024 · 1 comment
Closed

Group as tag in Prometheus #5147

mgoeppl opened this issue Oct 1, 2024 · 1 comment
Labels
area:metrics related to monitoring metrics feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor

Comments

@mgoeppl
Copy link

mgoeppl commented Oct 1, 2024

📑 I have found these related issues/pull requests

Now with the possibility of grouping monitors, there should be a group tag in the prometheus /metrics endpoint.
I personally have multiple monitors with the same name in different groups (e.g. mysql monitoring in both Docker and the service monitoring itself for quicker identification of the fault).
Also, in another setup, I have docker containers with the same name on multiple hosts. Identifying them with Prometheus alerts is not possible at this time.

🏷️ Feature Request Type

Other

🔖 Feature description

You should add the group name to the labels within the /metrics endpoint.

✔️ Solution

The following is the current layout of an example metric within the /metrics endpoint:
monitor_status{instance="instance", job="uptime-kuma", monitor_hostname="null", monitor_name="example.com", monitor_port="null", monitor_type="http", monitor_url="https://example.com"}

I'd like to be able to parse them by group, too:
monitor_status{instance="instance", job="uptime-kuma", monitor_hostname="null", monitor_name="example.com", monitor_port="null", monitor_type="http", monitor_group="group", monitor_url="https://example.com"}

❓ Alternatives

No response

📝 Additional Context

No response

@mgoeppl mgoeppl added the feature-request Request for new features to be added label Oct 1, 2024
@CommanderStorm CommanderStorm added area:metrics related to monitoring metrics type:enhance-existing feature wants to enhance existing monitor labels Oct 1, 2024
@CommanderStorm
Copy link
Collaborator

Hi Moritz, agree with the feature but I think tracking this in #3905 is better => closing as a duplciate

Also there are some unresolved questions around how nested groups should be handeld in said issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics related to monitoring metrics feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

No branches or pull requests

2 participants