-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: change 'Delete' button to grey instead of red #4290
Comments
Is this issue resolved? If not can I take this up? |
I don't think the proposed solution is a good idea, since it should still be red to signify a "danger action". But maybe we can think about hiding it in an overflow menu. |
That's why there is a modal that asks you to confirm to proceed. It's a good idea to keep that button red but I'd still be in favour of making this delete button grey, or if people have very strong views on red, maybe a red trash icon and a grey background to make it less intrusive.
Andrew
|
I made the changes, here is the Pull request |
Resolved by #4307 @iamabhshk FYI: next time please add |
Sure, thanks |
🛡️ Security Policy
Description
Hi - on a healthy setup, you'd want to see all green/neutral colours on your screen. The 'delete' button remains red. To demonstrate, consider this perspective. The red grabs your attention for no real reason. I'd suggest it be changed to grey.
👟 Reproduction steps
N/A
👀 Expected behavior
Grey button to look better
😓 Actual Behavior
Red button...
🐻 Uptime-Kuma Version
1.23.10
💻 Operating System and Arch
Almalinux kernel 6.6.8
🌐 Browser
Chrome
🐋 Docker Version
Kubernetes
🟩 NodeJS Version
No response
📝 Relevant log output
No response
The text was updated successfully, but these errors were encountered: