Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launching some games (Dota 2) is not tracked by ApplicationWatcher due to lack of WS_SYSMENU #2

Open
lostmsu opened this issue Sep 4, 2019 · 1 comment
Open

Launching some games (Dota 2) is not tracked by ApplicationWatcher due to lack of WS_SYSMENU #2

lostmsu opened this issue Sep 4, 2019 · 1 comment

Comments

@lostmsu
Copy link

lostmsu commented Sep 4, 2019 •
edited
Loading

OnApplicationWindowChange never fires, because ShellHook ignores all windows without WS_SYSMENU.

I think the logic in ShellHook.IsAppWindow deserves some explanation overall. For example, there's a check for IsWindowVisible, but it never tracks if window becomes visible after creation.

Perhaps, library user should be able to filter windows on their own.

Copied from justcoding121#19
@lostmsu
Copy link
Author

lostmsu commented Sep 4, 2019

Immediate fix available in 33a4dc5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lostmsu