Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using None-0 Ids for decks #132

Closed
phoorichet opened this issue Sep 19, 2018 · 1 comment
Closed

Using None-0 Ids for decks #132

phoorichet opened this issue Sep 19, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@phoorichet
Copy link
Contributor

From Christian

Sometimes the backend reports decks without Ids for the player.

For example, this is what one of the QA guys got:
{ “decks”: [ { “name”: “Default”, “heroId”: “4”, “cards”: [ { “cardName”: “Pyromaz”, “amount”: “4" }, { “cardName”: “Burrrnn”, “amount”: “2" }, { “cardName”: “Izze”, “amount”: “4" }, { “cardName”: “Zhatterer”, “amount”: “4" }, { “cardName”: “Rockky”, “amount”: “4" }, { “cardName”: “Blocker”, “amount”: “4" }, { “cardName”: “Cerberus”, “amount”: “1" }, { “cardName”: “Gargantua”, “amount”: “1" }, { “cardName”: “Zhampion”, “amount”: “2" }, { “cardName”: “Fire-Maw”, “amount”: “1" }, { “cardName”: “Modo”, “amount”: “1" }, { “cardName”: “Werezomb”, “amount”: “2" } ] } ] }

As you can see, the deck doesn’t have an Id parameter. I thought the server would always assign one, but maybe something went wrong somewhere? The problem is that without an Id, the game crashes upon start, as it’s used to retrieve the deck and in general setup the basic info for the game to start. Do you know of any reason why the server would return a deck without Id ?

Also, in the logs provided, the user initally correctly retrieves decks with Ids. It’s only at the second login, that he gets a deck without Ids.

@phoorichet phoorichet added the enhancement New feature or request label Sep 19, 2018
@phoorichet
Copy link
Contributor Author

phoorichet commented Sep 21, 2018

Since the protobuf omit empty values when they are zero values, we can starting using deck id starting from 1 to avoid this issue.

close #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant