fix: Fixed incorrect VerifySSL setting implementation (#989)

jeremytchang · web-flow · commit a4f1dec40804 · 2022-02-15T10:38:08.000-08:00
diff --git a/go/rtl/auth.go b/go/rtl/auth.go
@@ -44,7 +44,7 @@ type AuthSession struct {
 func NewAuthSession(config ApiSettings) *AuthSession {
 	tr := &http.Transport{
 		TLSClientConfig: &tls.Config{
-			InsecureSkipVerify: config.VerifySsl,
+			InsecureSkipVerify: !config.VerifySsl,
 		},
 	}
 	return &AuthSession{
@@ -53,6 +53,7 @@ func NewAuthSession(config ApiSettings) *AuthSession {
 	}
 }
 
+// The transport parameter may override your VerifySSL setting
 func NewAuthSessionWithTransport(config ApiSettings, transport http.RoundTripper) *AuthSession {
 	return &AuthSession{
 		Config:    config,

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ type AuthSession struct {`
`44`	`44`	`func NewAuthSession(config ApiSettings) *AuthSession {`
`45`	`45`	`tr := &http.Transport{`
`46`	`46`	`TLSClientConfig: &tls.Config{`
`47`		`- InsecureSkipVerify: config.VerifySsl,`
	`47`	`+ InsecureSkipVerify: !config.VerifySsl,`
`48`	`48`	`},`
`49`	`49`	`}`
`50`	`50`	`return &AuthSession{`
`@@ -53,6 +53,7 @@ func NewAuthSession(config ApiSettings) *AuthSession {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
	`56`	`+// The transport parameter may override your VerifySSL setting`
`56`	`57`	`func NewAuthSessionWithTransport(config ApiSettings, transport http.RoundTripper) *AuthSession {`
`57`	`58`	`return &AuthSession{`
`58`	`59`	`Config: config,`