add download link #323
add download link #323
Conversation
|
Perfect... I have been waiting for this so long! |
|
Works fine, already used on prod server |
|
We also use it on our production server. Please merge this @lokesh. It is pretty neat and much needed. |
lokesh
force-pushed
the
master
branch
3 times, most recently
from
de83cee
to
c1c0f87
Compare
|
This feature needs to be merged... please... |
|
That would be very useful! 😃 |
|
Hi, I'm looking for a documentation for download button...where did you explain how to use it? |
|
What is the blocker for this review that started eight months ago? We are in desperate need for this feature. |
|
Besides making the necessary changes to both the lightbox.js and lightbox.css, as well as placing the icon in the appropriate image directory, what else is needed to make the "download" button/link work? I've done the aforementioned and see the icon appear, but when clicked, the link just opens a new browser window with the appropriate image. What's missing? Any other files that need to be amended or installed? |
|
There seem to be conflicts that prevent merging. I could try to redo your patch against the current master... @madhums Is this fine with you? |
|
@direc85 sure go ahead! |
Adds a download link based on #312