Skip to content

Dynamic field values in prefix is not supported #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nigoel opened this issue Jun 1, 2015 · 21 comments
Closed

Dynamic field values in prefix is not supported #16

nigoel opened this issue Jun 1, 2015 · 21 comments
Labels

Comments

@nigoel
Copy link

nigoel commented Jun 1, 2015

Creation of different file paths in s3 for different kind of events or tracking log file is not supported.

For example, here folder prefixes based on fields "app" and "type" are not supported.
input {
file {
path => "//data//executors//logs/"
}
}

filter {
grok { match => ["path","/%{GREEDYDATA}/executors/%{GREEDYDATA:app}[.]%{GREEDYDATA}/logs/%{GREEDYDATA:type}"]
}
}
output {
s3{
.....................
.....................
prefix => "applogs/%{app}/%{type}"
}
}

nigoel pushed a commit to nigoel/logstash-output-s3 that referenced this issue Jun 1, 2015
@nigoel
Copy link
Author

nigoel commented Jun 1, 2015

Fix has been provided in https://github.com/nigoel/logstash-output-s3

@Onalu
Copy link

Onalu commented Jun 17, 2015

I'd like to see dynamic values on prefix too. I want to collect my logs in daily folders and there is no option for it now.

@nigoel maybe you should make a pull request since you already implemented a solution.

@nigoel
Copy link
Author

nigoel commented Jun 19, 2015

@Onalu Here it is #17

@shaharmor
Copy link

+1

nigoel pushed a commit to nigoel/logstash-output-s3 that referenced this issue Sep 10, 2015
@vaijab
Copy link

vaijab commented Oct 13, 2015

Any plans on implementing this?

@BDuelz
Copy link

BDuelz commented Dec 9, 2015

+1

2 similar comments
@obazoud
Copy link

obazoud commented Dec 9, 2015

+1

@zot420
Copy link

zot420 commented Dec 10, 2015

+1

@NoumanSaleem
Copy link

Would love this for all other string values like bucket

@cero-t
Copy link

cero-t commented Feb 9, 2016

+1

@beeva-luisgonzalez
Copy link

Please merge it!

1 similar comment
@ghost
Copy link

ghost commented Apr 14, 2016

Please merge it!

@ghost
Copy link

ghost commented Apr 14, 2016

@nigoel would you pull the latest version and merge your changes? So your repo is up-to-date. That would be awesome!! I've tried, but got conflicts I couldn't solve.

@ghost
Copy link

ghost commented Apr 20, 2016

@nigoel I am using your version of the plugin as I needed dynamic prefixes. Workers stop after they've uploaded once. It seems need_cleanup? throws an error if @empty_downloads[prefix] is nil.
I couldn't create a pull request for your repository hence posting it here. The fix should look like this (or similar, I am not a ruby programmer):

  public
  def need_cleanup?(prefix)
    if @empty_uploads[prefix].nil?
      return false
    end
    return @empty_uploads[prefix] > @no_event_wait
  end

@suyograo suyograo added the P2 label Apr 26, 2016
@asemt
Copy link

asemt commented Jun 30, 2016

+1

4 similar comments
@s4nch3z
Copy link

s4nch3z commented Jul 9, 2016

+1

@dgeebs
Copy link

dgeebs commented Jul 13, 2016

+1

@donovankim
Copy link

+1

@wagner
Copy link

wagner commented Aug 8, 2016

+1

@vaijab
Copy link

vaijab commented Aug 8, 2016

Adding +1 does not do anything, just spams us all.

@ph
Copy link
Contributor

ph commented Aug 30, 2016

I am closing this issue in favor of #4, so all the discussion can happen in the same place.
I have started on working on that feature.

@ph ph closed this as completed Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests