Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename this plugin #8

Open
suyograo opened this issue Jul 22, 2015 · 7 comments
Open

Rename this plugin #8

suyograo opened this issue Jul 22, 2015 · 7 comments

Comments

@suyograo
Copy link
Contributor

Translate as a name is not apt for this plugin. It does more than translate and probably be named logstash-filter-lookup or something. Thoughts? Is lookup too generic?

@gmoskovicz
Copy link

I like lookup. At least it gives an idea that this is a more generic plugin.

@suyograo 👍 😄

@dadoonet
Copy link

+1

@purbon
Copy link

purbon commented Aug 28, 2015

I like the renaming, this recall me to a dictionary lookup, that is what this plugin mostly does 😄

@jelmerdereus
Copy link

@suyograo I like it too

maybe hashlookup is a good tag.

dictionary lookups improve speed incredibly. We just pushed 50% more logs p/second in Elasticsearch using a hash lookup with translation.

@guyboertje
Copy link

@jelmerdereus - this is good to hear. Please add some detail of what you had before and after.

@jelmerdereus
Copy link

@guyboertje it did a lookup real fast but no translation was done before transmitting it over the network. It was faster because it did less work. My apologies for not correcting that in this issue before.

In the next weeks I will get time from my employer to delve into this. When we reach the required performance, I'll let you know how.

@guyboertje
Copy link

@jelmerdereus - Sorry I don't understand. Are you saying that the latest version is faster than previously or that a different config (say using mutate) was slower that a newer config using translate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants