Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import - Add support for pdf highlights #196

Open
1 of 2 tasks
aforank opened this issue Dec 20, 2024 · 0 comments
Open
1 of 2 tasks

Import - Add support for pdf highlights #196

aforank opened this issue Dec 20, 2024 · 0 comments
Labels
enhancement New feature or request import

Comments

@aforank
Copy link

aforank commented Dec 20, 2024

Search first

  • I searched and no similar issues were found

What Happened?

I imported my existing graph for the first time, and one of the most noticeable issues I encountered is that the Edn files were not imported. It seems these files contain my highlights from a PDF. However, when I open the corresponding PDF files, my highlights no longer appear, and any references to these highlights are also broken (appears in yellow), as shown below.

image

image

EDN file content

{:highlights [{:id #uuid "647f43c6-7439-4c97-851f-a4286c04b11e", :page 73, :position {:bounding {:x1 11, :y1 4, :x2 674, :y2 359, :width 682.0000000000001, :height 383.62500000000006}, :rects (), :page 73}, :content {:text "[:span]", :image 1686062020889}, :properties {:color "yellow"}}], :extra {:page 81}}

100's of similar errors were shown after import.

Reproduce the Bug

Import a page with any PDF highlighting.

Expected Behavior

No response

Files

No response

Browser, Desktop or Mobile Platform Information

No response

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@logseq-cldwalker logseq-cldwalker changed the title Import - Skipped file since its format is not supported (edn file) Import - Add support for pdf highlights Dec 20, 2024
@logseq-cldwalker logseq-cldwalker added import enhancement New feature or request labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request import
Projects
None yet
Development

No branches or pull requests

2 participants