Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local logsearch manifest.yml #11

Open
dpb587 opened this issue Feb 3, 2015 · 2 comments
Open

Remove local logsearch manifest.yml #11

dpb587 opened this issue Feb 3, 2015 · 2 comments
Labels

Comments

@dpb587
Copy link
Contributor

dpb587 commented Feb 3, 2015

Seems like we've committed a sample logsearch manifest.yml for logsearch-boshrelease. I don't think that's a good idea because then we'd have to maintain it in separate places (logsearch-boshrelease repo and here). In this case, v18 dropped collectd which this local manifest was including and caused unnecessary confusion.

Instead, I think we should be copying the examples/bosh.yml into the local directory, whether that's by cloning the repo or doing a wget to the raw file on github.

https://github.com/logsearch/workspace/blob/master/_setup/runtime/workspace_skel/environments/local/test/logsearch/manifest.yml

@dpb587 dpb587 added the bug label Feb 3, 2015
@dpb587
Copy link
Contributor Author

dpb587 commented Feb 3, 2015

@mrdavidlaing, agreed?

@mrdavidlaing
Copy link
Member

@dpb587, I've gone round in circles on this one a bit, since the /environments/local/test/logsearch/manifest.yml ended up becoming quite workspace specific. (Note how it makes use of some workspace specific environment variables, eg TENANT_NUMBER, and is configured to pull its filter config from https://github.com/logsearch/workspace/blob/master/_setup/runtime/workspace_skel/environments/local/test/logsearch/logsearch-for-weblogs/logsearch-for-weblogs.filters.conf)

If you think it still belongs in logsearch-boshrelease, lets move it there but give it a name indicating that it is for use in the logsearch workspace.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants