Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for not rendering chat widgets for all data messages #371

Open
agazso opened this issue Sep 11, 2023 · 0 comments
Open

Support for not rendering chat widgets for all data messages #371

agazso opened this issue Sep 11, 2023 · 0 comments
Labels
design & ui Design is different from what is implemented enhancement New feature or request

Comments

@agazso
Copy link
Contributor

agazso commented Sep 11, 2023

Currently all DataMessages sent between the objects result in a rendered component. However there were discussions where sometimes there could be better UX if the DataMessage would not display a new bubble, but change the state of an existing one. With the current implementation there is no way to do it, and it would be great to cover this. For example the WakuObjectDescriptor could have a function that returns a boolean based on the message and the current state if the message needs to be displayed or not, or the onMessage could return a boolean. This is getting more interesting with the external object because here we need to decide if we want to display a chat bubble or not before the iframe is displayed and logic runs in that.

Originally from #359

@agazso agazso added enhancement New feature or request design & ui Design is different from what is implemented labels Sep 11, 2023
@agazso agazso mentioned this issue Sep 11, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design & ui Design is different from what is implemented enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant