Skip to content

Commit 96a67fe

Browse files
committed
[HWORKS-1822] Infer valid serving name based on the model name
1 parent aca9a60 commit 96a67fe

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

python/hsml/model.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import json
1818
import logging
1919
import os
20+
import re
2021
import warnings
2122
from typing import Any, Dict, Optional, Union
2223

@@ -236,7 +237,7 @@ def deploy(
236237
"""
237238

238239
if name is None:
239-
name = self._name
240+
name = self._get_default_serving_name()
240241

241242
predictor = Predictor.for_model(
242243
self,
@@ -366,6 +367,9 @@ def get_training_dataset_provenance(self):
366367
"""
367368
return self._model_engine.get_training_dataset_provenance(model_instance=self)
368369

370+
def _get_default_serving_name(self):
371+
return re.sub(r"[^a-zA-Z0-9]", "", self._name)
372+
369373
@classmethod
370374
def from_response_json(cls, json_dict):
371375
json_decamelized = humps.decamelize(json_dict)

python/hsml/model_serving.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def get_deployments(self, model: Model = None, status: str = None):
126126
`RestAPIError`: If unable to retrieve deployments from model serving.
127127
"""
128128

129-
model_name = model.name if model is not None else None
129+
model_name = model._get_default_serving_name() if model is not None else None
130130
if status is not None:
131131
self._validate_deployment_status(status)
132132

@@ -208,7 +208,7 @@ def create_predictor(
208208
"""
209209

210210
if name is None:
211-
name = model.name
211+
name = model._get_default_serving_name()
212212

213213
return Predictor.for_model(
214214
model,

0 commit comments

Comments
 (0)