From 5e8dd8fff047aa659ddec108c3599a22884d211a Mon Sep 17 00:00:00 2001 From: "Anna (Anya) Parker" <50943381+anna-parker@users.noreply.github.com> Date: Tue, 30 Jul 2024 15:15:04 +0200 Subject: [PATCH 1/4] Add version comments --- kubernetes/loculus/values.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/kubernetes/loculus/values.yaml b/kubernetes/loculus/values.yaml index bf6c770dd..b6d32c75a 100644 --- a/kubernetes/loculus/values.yaml +++ b/kubernetes/loculus/values.yaml @@ -1030,6 +1030,13 @@ defaultOrganismConfig: &defaultOrganismConfig example: GJP123 position: first noEdit: true + - name: version_comments + displayName: Version Comments + definition: Additional comments about version + guidance: Used when revising sequences + example: Previous version filled Ns with the reference sequence. + header: Submission details + position: first preprocessing: - &preprocessing version: 1 From 8148ac46e9e32b54d76ccb52c7493b80f5136b36 Mon Sep 17 00:00:00 2001 From: "Anna (Anya) Parker" <50943381+anna-parker@users.noreply.github.com> Date: Tue, 30 Jul 2024 15:28:14 +0200 Subject: [PATCH 2/4] fix sequence details page --- kubernetes/loculus/templates/_common-metadata.tpl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kubernetes/loculus/templates/_common-metadata.tpl b/kubernetes/loculus/templates/_common-metadata.tpl index c79d88c27..df48bee97 100644 --- a/kubernetes/loculus/templates/_common-metadata.tpl +++ b/kubernetes/loculus/templates/_common-metadata.tpl @@ -22,6 +22,10 @@ fields: type: int notSearchable: true hideOnSequenceDetailsPage: true + - name: version_comments + type: string + notSearchable: true + header: Submission details - name: submissionId type: string header: Submission details From 1fa674cb5cf9fd42cda65c28e2375ee21578dc4a Mon Sep 17 00:00:00 2001 From: "Anna (Anya) Parker" <50943381+anna-parker@users.noreply.github.com> Date: Tue, 30 Jul 2024 15:46:57 +0200 Subject: [PATCH 3/4] Just use as simple metadata field as otherwise not showing up on details page or breaking LAPIS --- kubernetes/loculus/templates/_common-metadata.tpl | 4 ---- kubernetes/loculus/values.yaml | 10 +++------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/kubernetes/loculus/templates/_common-metadata.tpl b/kubernetes/loculus/templates/_common-metadata.tpl index df48bee97..c79d88c27 100644 --- a/kubernetes/loculus/templates/_common-metadata.tpl +++ b/kubernetes/loculus/templates/_common-metadata.tpl @@ -22,10 +22,6 @@ fields: type: int notSearchable: true hideOnSequenceDetailsPage: true - - name: version_comments - type: string - notSearchable: true - header: Submission details - name: submissionId type: string header: Submission details diff --git a/kubernetes/loculus/values.yaml b/kubernetes/loculus/values.yaml index b6d32c75a..21b09c725 100644 --- a/kubernetes/loculus/values.yaml +++ b/kubernetes/loculus/values.yaml @@ -1009,6 +1009,9 @@ defaultOrganismConfig: &defaultOrganismConfig rangeSearch: true preprocessing: inputs: {input: nextclade.coverage} + - name: version_comments + displayName: Version Comments + header: Submission details website: &website tableColumns: - sample_collection_date @@ -1030,13 +1033,6 @@ defaultOrganismConfig: &defaultOrganismConfig example: GJP123 position: first noEdit: true - - name: version_comments - displayName: Version Comments - definition: Additional comments about version - guidance: Used when revising sequences - example: Previous version filled Ns with the reference sequence. - header: Submission details - position: first preprocessing: - &preprocessing version: 1 From a0945a56d93c03c3d761b4e1a05ea99f98837ec0 Mon Sep 17 00:00:00 2001 From: "Anna (Anya) Parker" <50943381+anna-parker@users.noreply.github.com> Date: Tue, 30 Jul 2024 20:23:02 +0200 Subject: [PATCH 4/4] Change version_comments to version_comment --- kubernetes/loculus/values.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kubernetes/loculus/values.yaml b/kubernetes/loculus/values.yaml index 21b09c725..1c0e26ac4 100644 --- a/kubernetes/loculus/values.yaml +++ b/kubernetes/loculus/values.yaml @@ -1009,8 +1009,8 @@ defaultOrganismConfig: &defaultOrganismConfig rangeSearch: true preprocessing: inputs: {input: nextclade.coverage} - - name: version_comments - displayName: Version Comments + - name: version_comment + displayName: Version Comment header: Submission details website: &website tableColumns: