Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Welcome message configurable #3161

Open
chaoran-chen opened this issue Nov 2, 2024 · 4 comments
Open

Make Welcome message configurable #3161

chaoran-chen opened this issue Nov 2, 2024 · 4 comments
Labels
config Configuration related issues, i.e. helm processing feature Feature proposal website Tasks related to the web application

Comments

@chaoran-chen
Copy link
Member

I think that it would be nice if we can make the Welcome message on the landing page configurable. At the moment, it always says

Welcome to {website name}, a system for sharing pathogen genome data.

Instead, I'd suggest adding a config like welcomeMessageHTML that an admin can set to overwrite this message.

@chaoran-chen chaoran-chen added website Tasks related to the web application config Configuration related issues, i.e. helm processing labels Nov 2, 2024
@chaoran-chen chaoran-chen added the feature Feature proposal label Nov 2, 2024
@fhennig
Copy link
Contributor

fhennig commented Nov 4, 2024

Hmm, I can see it being useful in principle. Should it be directly in HTML (as the suffix on your suggested config option suggests)? Would it still be possible to use website name as a template variable somehow?

@chaoran-chen
Copy link
Member Author

HTML would be most flexible and we already have a few places where people can insert HTML through the config such as additionalHeadHTML and I think also for the yellow top banner (that shows up for some instances).

Would it still be possible to use website name as a template variable somehow?

By default, if the config is not set / set to null, I'd say that we will still display the text as now. This will be done directly in the website code, meaning that the new config will be considered optional for the website application. If the admin defines a message, I don't know whether they can do some templating through Helm magic but I wouldn't implement a feature specifically.

@corneliusroemer
Copy link
Contributor

To be explicit, I think you're talking about this, correct?

image

@chaoran-chen
Copy link
Member Author

Yes, exactly! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration related issues, i.e. helm processing feature Feature proposal website Tasks related to the web application
Projects
Status: No status
Development

No branches or pull requests

3 participants