Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow notifications] Minor thought... shouldn't it also reset the last_email_run state when the "Enable email notifications" box has become ticked? Else the user would receive a flood of old notifications as soon as they [re-]enable e-mails! #94

Closed
finnlewis opened this issue May 7, 2024 · 0 comments · Fixed by #96

Comments

@finnlewis
Copy link
Member

          Minor thought... shouldn't it also reset the `last_email_run` state when the "Enable email notifications" box has become ticked? Else the user would receive a flood of old notifications as soon as they [re-]enable e-mails!

Or perhaps simpler, for the same effect, just update state every time within hook_cron during the early-return?

Originally posted by @graham-web in #93 (comment)

finnlewis pushed a commit that referenced this issue May 21, 2024
* Refactored last run setting and checking into a service
* Reset last run state when enabling email sending #94
@finnlewis finnlewis mentioned this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant