Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of subsites pages without a banner causing accessibility issue with page title #26

Open
cjstevens78 opened this issue Mar 30, 2021 · 2 comments

Comments

@cjstevens78
Copy link
Contributor

The <h1> title for subsites pages is contained within the banner area. When a page is published without a banner it fails accessibility checks due to not having an <h1> title. @willguv suggested that the intention for subsites is to always have a banner as part of the page structure. If this is the case then there should be some kind of validation in place to prevent a page being published without one. See screenshot of a page on Croydon that was published without a banner. Screen readers are looking for a page title <h1> but instead find a section title <h2>.

Screenshot 2021-03-29 at 13 44 39

@andybroomfield
Copy link
Contributor

Just to add, it's not always the case a subsite will have a banner.
eg. https://www.brighton-hove.gov.uk/how-stay-active-home
The missing <h1> is down to the subsites banner changing to a paragraph, so the block does not get rendered if no banner is set, so it will not render the page title.

I think the best cause of action is to provide a default <h1> with the title if the banner is not set, rather than assume it will always be present and make it a required field, as we don't know if every subsite will contain a banner image.

@keelanfh
Copy link
Member

@msayoung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants