Rename Secondary banner to basic, Primary banner to advanced, and swap order (Was rationalise the subsite banner type paragraphs)

[andybroomfield]

Rename secondary banner to basic banner, that is just an image, which renders it as full background CSS and overlays the sub site title.

Sub site represents a departure on how the overlay banners are implemented compared to the Campaigns module orignally built at BHCC, which has implications for content designers and themers.

At BHCC, content designers choose a banner image and the colourway from two select boxes.

This renders a block using css as a background image and then displays the campaigns title over the top on all campaign pages. The background is tinted / hued based on the colourway scheme selected.

The old BHCC implementation is handled on the campaign overview node itself (its part of the content type as seperate fields).

Subsites replaces this setup by making the banner a paragraph type, offering the choice of a primary and secondary banner. The primary banner offers a lot of options and its not enirley sure what the relvenacy of them are. For example there is title, text, logo, url fields.

Since no BHCC campaign has this pattern, and the included block still relies on their being an image url (see #14). Its not clear what the extra fields do? I assume this is a Lambeth pattern. Is there an example and user research on why use this?

As most campaigns / sub sites will use the banner image, would it be better to swap the order around?
What are the implications of renaming them? I think to start with this could be an admin label change, but if there are in use then a config change and update is going to be nessecary.

Also as the banners have now changed to using paragraph types and media entities instead of a plain image (a good idea). The templates will need to be updated. Ideally with less excess markup as possible.

[msayoung]

Very late response to this question!

I'd support this as we're currently only using the Secondary banner in microsites, and without a Primary the name makes no sense.