Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset changes need puma restarts #85

Open
pushcx opened this issue Feb 3, 2024 · 0 comments
Open

Asset changes need puma restarts #85

pushcx opened this issue Feb 3, 2024 · 0 comments

Comments

@pushcx
Copy link
Member

pushcx commented Feb 3, 2024

The playbook reloads the puma service when possible because it's faster.

I deployed a js-only fix a few minutes ago. Ansible did correctly recompile assets, but the new version didn't appear in prod until I manually ran systemctl restart lobsters-puma. I expect that the same problem would happen with css-only changes, Rails uses the same mechanism of hashing asset contents to use as URL names.

Tasks in roles/lobsters/tasks/main.yml need to update to detect if there were changes in app/assets. The recompile assets task only needs to run if paths there changed. And then the phased restarted puma task shouldn't run and the restart puma task should run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant