-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add support for readme.md display #25
Comments
Hi @yntelectual thanks for using the plugin. Sure, will check it out on how we can be implemented as at times the docs content might be lengthy. |
Excellent, it could look the same as GitHub Insights https://roadie.io/backstage/plugins/github-insights/?utm_source=backstage.io&utm_medium=marketplace&utm_campaign=github-insights |
I recently created a custom README card plugin partially because the gitlab plugin did not have one and because I wanted to experience the joy/pain/emotions of building a backstage plugin. If y'all want help on this, I'd be happy to contribute. |
@lackerman we just started working too, sure please contribute. |
We have pushed our initial changes to readmecard branch, please take a look. @lackerman |
@lackerman any thoughts on the code?. |
apologies for the delay folks. I'll take a look |
Hi @satrox28, I've found a few things which I've listed below The following function is unused The file path needs to be encoded, as per the Gitlab docs Images are not showing up in the README And the deep link doesn't appear to work. The link rendered does not include the project path Otherwise, it looks good, renders better than mine ;) My only favour would be, could we make it a standalone component (perhaps all the widgets could be standalone) so that I could import them on whichever tab I wanted. |
+1 for the standalone components - right now we either get all gitlab insights in single component or none, it would be great if we could, for example, just take CICD widget and put it on the entity main page. ANd for readme it definitely makes sense - readme is sth that we want to show as soon as possible, not only once user goes to gitlab tab. Thanks for the quick delivery btw |
hi @satrox28 have you had any time to finish the work on this new feature and the export of individual components? Or is there a way we could help? Thanks |
Hi @yntelectual We got stuck with few other priorities but please feel to raise a PR if you would like to contribute. We will for sure look in to it after the holidays. |
Hi @yntelectual @lackerman Sorry, we still working on other features. Can you please give it a try. |
Hi @yntelectual @lackerman |
@satrox28 I tried it out and it worked without issue! Thank you so much! I see the README card is not there yet. Do you need help on that one? |
As per the discussion on loblaw-sre#25 this is the work I did to enable this functionality with a custom plugin.
As per the discussion on loblaw-sre#25 this is the work I did to enable this functionality with a custom plugin. Signed-off-by: Leo Ackerman <[email protected]>
hi, thanks for the gitlab plugin.
This is a feature request to support rendering projects readme on the component entity page - as extra widget probably.
Backstage has its own techdocs plugin - but that fulfills different use case then a simple project readme.
The gitlab api provides a readme link in the api response as
"readme_url"
attribute. The idea is to simply fetch the file from the provided location and render it on the component page with markdown renderer.Thanks
The text was updated successfully, but these errors were encountered: