-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to protect user from fake site login with lnurl-auth #257
Comments
The LNURL-auth specification has protection against this. A unique key is derived for each domain you authenticate with. So the key is not shared between domains, therefore phishing is not really possible. |
1,fake site get k1 and lnurl from site on server and show lnurl to user. fake site domain is very similar to site. |
That would just authenticate with the fake website, not the real one. A unique key being used for authentication is derived from the domain you're talking with. See here: Lines 8 to 11 in 0318227
|
no, fake site also can login with api.example.com. |
@hsjoberg I think @pynixwang is saying that the middleman would retrieve the challenge from the real site and provide that to the user out of band, and then receive the auth response from the user, allowing the middleman to apply it themselves to open a session with the real site. |
The wallet will generate a different keypair for each domain it connects to. The protection is not at the The attacker can only do two things:
|
@BitcoinErrorLog What do you mean by out-of-band specifically? If it's a fake website then the user would authenticate using a unique key for that domain and not the same key as they would use for the real website. I suppose the man-in-the-middle attack does work if the user has only ever interacted with the fake website. But it would never work if the user already has an account on the real one. |
@pynixwang Yes the fake site can login to api.example.com, but it would not be the same key being used thus not the same account on the site. |
@hsjoberg but key is generated for api.example.com, not fake site |
if user does not pay attention to login url show in login page and click login, fake site can get user credentials.
The text was updated successfully, but these errors were encountered: