Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SiriusPVTimeSerie #409

Open
xresende opened this issue Mar 21, 2020 · 0 comments
Open

SiriusPVTimeSerie #409

xresende opened this issue Mar 21, 2020 · 0 comments
Assignees
@xresende @anacso17

Comments

@xresende
Copy link
Contributor

xresende commented Mar 21, 2020 •
edited
Loading

dev-packages/siriuspy/siriuspy/epics/pv_time_serie.py

Line 1 in adbe62d

"""SiriusPVTimeSerie Class."""

@anacso17 , while going through siriuspy various modules for clean up code, I noticed that SiriusPVTimeSerie does not implement PV-type functionality, as all the other modules in siriuspy.epics subpackage do. It merely uses one of its attributes of type PV to implement its methods. None of its methods implements PV methods. The class is like any other class that connects to PVs...

I think this module does not belong to this subpackage. What do you think? It looks like it could be implemented as a Device class...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xresende xresende

@anacso17 anacso17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xresende @anacso17