Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP-07 client does not work correctly with inproper permission request #3

Open
jg1uaa opened this issue Apr 2, 2023 · 5 comments
Open

Comments

@jg1uaa
Copy link
Contributor

jg1uaa commented Apr 2, 2023

Hi, I am testing horse with my nostr-signing-device-emulator (https://github.com/jg1uaa/nsdemu).
I tried horse with iris (https://iris.to/), Snort(https://snort.social/) and nostter(https://nostter.vercel.app), and I found permission window of horse looks something strange compared wiith nos2x (https://github.com/fiatjaf/nos2x).

For example:
(iris.to) login with NIP-07 → COM port selection → (no permission required) → login with timeline display
(snort) login with NIP-07 → COM port selection → "read your public key" and "read your list of preferred relays" requested → window does not dismiss all buttons in permission window, only close with [x]
(nostter) login with NIP-07 → COM port selection → (no permission required) → login with no timeline display

Normally, good-working-example by nos2x:
(iris.to) login with NIP-07 → "read your public key" requested → login with timeline display
(snort) login with NIP-07 → "read your public key" requested → "read your public key" and "read your list of preferred relays" requested → login with timeline display
(nostter) login with NIP-07 → "read your public key" requested → "read your public key" and "read your list of preferred relays" requested → login with timeline display

Request/Response(from user) of permissions are not set correctly, client does not work properly.
What can I help to solve this problem?

@motorina0
Copy link
Collaborator

I assume the same issue reproduces when using both the physical hardware and simulator. Can you please confirm?

It looks to be a react issue in the pop-up view of horse.

Nos2x:

image

Horse:

image

@motorina0
Copy link
Collaborator

motorina0 commented Apr 3, 2023

@jg1uaa the simulator looks pretty cool. Can it be used on MacOS also?

@jg1uaa
Copy link
Contributor Author

jg1uaa commented Apr 3, 2023

@motorina0 I don't have Apple machine so I cannot test nsdemu on MacOS. I succeeded to build nsdemu on other *BSD brothers such as FreeBSD/NetBSD so I think "maybe work" or "need small fix".

@motorina0
Copy link
Collaborator

@jg1uaa

I assume the same issue reproduces when using both the physical hardware and simulator. Can you please confirm?

@jg1uaa
Copy link
Contributor Author

jg1uaa commented Apr 9, 2023

@motorina0 is this problem? (with nsdemu on OpenBSD)

image

This was referenced May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants