Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Feedback penalty configuration should disallow '0' for clarity #357

Open
navilan opened this issue Aug 5, 2014 · 2 comments
Open

Feedback penalty configuration should disallow '0' for clarity #357

navilan opened this issue Aug 5, 2014 · 2 comments

Comments

@navilan
Copy link
Contributor

navilan commented Aug 5, 2014

Currently, we allow feedback penalty to be set to 0 and interpret it as "No penalty". For the sake of clarity, its better to disallow 0. /cc @kjdav

navilan added a commit to navilan/ost that referenced this issue Aug 5, 2014
- Ensure that penalty gets translated into credit when
  applied to student exercises.
@Dantemss
Copy link
Member

Dantemss commented Aug 5, 2014

This is one of those things I would do differently: I would probably disallow null (in the model and database), remove the is_feedback_required_for_credit setting and just have 0 mean "off". Of course, no point in modifying all the code right now. Maybe in tutor 3.

@navilan
Copy link
Contributor Author

navilan commented Aug 5, 2014

@Dantemss - Agreed. That's a better design. My approach was to only add code. (is_feedback_required_for_credit) was already in use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants