Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use raw strings for latex backslash espace sequences #182

Closed
wants to merge 1 commit into from
Closed

use raw strings for latex backslash espace sequences #182

wants to merge 1 commit into from

Conversation

newville
Copy link
Member

should fix #181

Copy link
Collaborator

@lebigot lebigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

These 13 changes should indeed fix the 13 warnings from #181.

Now, in order to accommodate Python 2, the 3 u'…' should be changed to u'…\\…' instead of r'…' (double escaping of the backslashes).

@lebigot
Copy link
Collaborator

lebigot commented Dec 26, 2023

I understand that I cannot conveniently directly modify this Pull Request because this would imply updating the master branch of lmfit. So if you can do the 3 changes, that would be great! Otherwise I can do a PR on lmfit/uncertainties. :)

@newville
Copy link
Member Author

@lebigot Python 2 had extended support but reached end-of-life 4 years ago. I hope you'll understand that I think it is not worth supporting.

I may not remember subtleties of Python2, but I don't quite understand why those u'..' strings would need changing to use double backslash while others close by that were not u'...' in the current master would be OK to leave as r'...'. So, I'm not 100% sure what would be the best changes to make to allow support for Python 2. You could consider merging this and then fixing it as you like.

FWIW, you were invited to join the lmfit organization. These invitations expire after 7 days, but I just resent it. I hope you'll have time to accept that invitation.

Please consider the offer in #180. We're willing to support this great library and try to move it forward. If you take a few steps to help us be able to push releases to PyPI and offer advice when you can, that would be tremendously helpful and very much appreciated. Otherwise, we could change the name of the forked project.

Cheers!

@newville newville mentioned this pull request Jan 15, 2024
@lmfit lmfit closed this by deleting the head repository Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.1.7] SyntaxWarning: invalid escape sequence '\<something>' with Python 3.12
3 participants