Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umap with NumPy 2.0.0 fails due to return_inverse in unique #1138

Open
seberg opened this issue Jul 11, 2024 · 0 comments
Open

Umap with NumPy 2.0.0 fails due to return_inverse in unique #1138

seberg opened this issue Jul 11, 2024 · 0 comments

Comments

@seberg
Copy link

seberg commented Jul 11, 2024

return_inverse returns something different even for axis=0. This was likely a mistake in NumPy 2, and we will probably revert it (not for axis=None). If you care for working correctly with NumPy 2.0 and have the time, adding:

inverse = inverse.reshape(-1)

would be safe way avoid a regression for this version either way.

xref numpy/numpy#26738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seberg