-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store the image moderation and text moderation logs #3478
base: operation-202407
Are you sure you want to change the base?
Conversation
Co-authored-by: CodingWithTim <[email protected]>
…r CPU environments (lm-sys#3434)
@connorchenn Thanks for the contribution. This is amazing work!
Co-authored-by: Tim Li <[email protected]> Co-authored-by: CodingWithTim <tim@inst-builder-debian-12-build-build-4zqb5.us-central1-a.c.gce-image-builder.internal>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick first pass. overall looks good to me!
@@ -0,0 +1,167 @@ | |||
import datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see we implement this abstraction!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @BabyChouSr left some comments
def flash_buttons(): | ||
def flash_buttons(dont_show_vote_buttons: bool = False): | ||
if dont_show_vote_buttons: | ||
yield [no_change_btn] * 4 + [enable_btn] * 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this actually ends up breaking the ui - need to keep yield + return pattern
+ [disable_btn] * 4 | ||
+ [no_change_btn] * 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why x4 + x3 vs x7 before
Co-authored-by: Wei-Lin Chiang <[email protected]>
Co-authored-by: CodingWithTim <tim@inst-builder-debian-12-build-build-4zqb5.us-central1-a.c.gce-image-builder.internal>
Co-authored-by: CodingWithTim <tim@inst-builder-debian-12-build-build-4zqb5.us-central1-a.c.gce-image-builder.internal>
Right now, we don't store the text moderation and image moderation info when it can be very helpful.