Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the image moderation and text moderation logs #3478

Open
wants to merge 43 commits into
base: operation-202407
Choose a base branch
from

Conversation

BabyChouSr
Copy link
Collaborator

Right now, we don't store the text moderation and image moderation info when it can be very helpful.

@BabyChouSr BabyChouSr marked this pull request as ready for review August 16, 2024 05:14
Copy link
Member

@infwinston infwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick first pass. overall looks good to me!

@@ -0,0 +1,167 @@
import datetime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see we implement this abstraction!

fastchat/serve/gradio_block_arena_anony.py Outdated Show resolved Hide resolved
Copy link
Member

@infwinston infwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @BabyChouSr left some comments

fastchat/serve/gradio_block_arena_named.py Outdated Show resolved Hide resolved
def flash_buttons():
def flash_buttons(dont_show_vote_buttons: bool = False):
if dont_show_vote_buttons:
yield [no_change_btn] * 4 + [enable_btn] * 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually ends up breaking the ui - need to keep yield + return pattern

fastchat/serve/gradio_block_arena_vision_anony.py Outdated Show resolved Hide resolved
Comment on lines 369 to 370
+ [disable_btn] * 4
+ [no_change_btn] * 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why x4 + x3 vs x7 before

fastchat/serve/gradio_block_arena_vision_named.py Outdated Show resolved Hide resolved
fastchat/serve/gradio_web_server.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants