Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3501 (VLLM): TypeError: top_k must be an integer, got float #3533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #3501 (VLLM): TypeError: top_k must be an integer, got float #3533

wants to merge 1 commit into from

Conversation

surak
Copy link
Collaborator

@surak surak commented Sep 23, 2024

VLLM needs top_j to be int, not float

Why are these changes needed?

For VLLM to work again

Related issue number (if applicable)

Closes #3501

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • [ x I've made sure the relevant tests are passing (if applicable).

@surak
Fix lm-sys#3501
bbce136 
VLLM needs top_j to be int, not float
@surak surak changed the title Fix #3501 Fix #3501 (VLLM): TypeError: top_k must be an integer, got float Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate vllm Error, TypeError: top_k must be an integer, got float
1 participant
@surak