Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for 4bit quantization from transfomer library. #1798

Open
harpomaxx opened this issue Jun 27, 2023 · 7 comments · May be fixed by #3476
Open

support for 4bit quantization from transfomer library. #1798

harpomaxx opened this issue Jun 27, 2023 · 7 comments · May be fixed by #3476
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@harpomaxx
Copy link

Loading a vicuna13B using 4bit quantization from the transformers library is possible load_in_4bit. How difficult could be for Fastach to support it?

@cidtrips
Copy link
Contributor

Honestly, it's updating to transformers 4.30, adding one other dependency package, and about 8 changes in the code if I recall correctly. Plus it works with multi-gpus.

Unfortunately I lost my changes from my running copy when I updated for the API updates, but I think most of the work is already done in my fork.

@merrymercy
Copy link
Member

Contributions are welcome

@merrymercy merrymercy added enhancement New feature or request good first issue Good for newcomers labels Jul 1, 2023
@02shanks
Copy link

02shanks commented Aug 7, 2024

@merrymercy is this issue still open for contribution?

@surak
Copy link
Collaborator

surak commented Aug 8, 2024

@02shanks absolutely!!!!

@02shanks
Copy link

02shanks commented Aug 8, 2024

@surak as this is my first code contribution, could you please guide me through the process? Where should I start?

@surak
Copy link
Collaborator

surak commented Aug 10, 2024

Well, the usual:

  • fork the repo,
  • branch it into a relevant name,
  • and contribute ONLY those changes related to the issue.
  • keep the repo up-to-date with the main branch, as this makes for an easier merge
  • comment it where applicable
  • once it's good enough, do a merge request. We will look into it and people will review it.

Nothing special, really!

@02shanks
Copy link

@surak @merrymercy I have just created the PR. Can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants