[flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 18 #86463

h-vetinari · 2024-03-25T03:44:11Z

I had been under the impression that flang had already been able to compile BLAS/LAPACK and OpenBLAS successfully (c.f. #64750, #67675, #70458).

However, while trying to use flang 19.0.0 (as of edf5782) to compile OpenBLAS 0.3.27, there's a missing omp_lib module

[...]
[3643/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\stplqt.f.obj
[3644/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\stplqt2.f.obj
[3645/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\stpmlqt.f.obj
[3646/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_2stage.f.obj
[3647/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F.obj
FAILED: CMakeFiles/LAPACK_OVERRIDES.dir/lapack-netlib/SRC/ssytrd_sb2st.F.obj 
%BUILD_PREFIX%\Library\bin\flang.exe -I%SRC_DIR%\lapack-netlib\SRC -I%SRC_DIR%\lapack-netlib\LAPACKE\include -fopenmp -fopenmp -ffixed-line-length-72 -o CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F.obj -c CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F-pp.f
error: Semantic errors in CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F-pp.f
D:\\bld\\openblas_1719536014536\\work\\lapack-netlib\\SRC\\ssytrd_sb2st.F:237:11: error: Cannot read module file for module 'omp_lib': Source file 'omp_lib.mod' was not found
        use omp_lib
            ^^^^^^^

Previously:

While trying¹ to use flang 18.1.2 to compile the latest OpenBLAS 0.3.26 (aside from from backporting a small fix due to flang 18 being stricter on unknown flags), things fail pretty early with what looks like a parsing problem...

[2005/19090] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\sgbcon.f.obj
FAILED: CMakeFiles/LAPACK_OVERRIDES.dir/lapack-netlib/SRC/sgbcon.f.obj 
%BUILD_PREFIX%\Library\bin\flang.exe -I%SRC_DIR%\lapack-netlib\SRC -I%SRC_DIR%\lapack-netlib\LAPACKE\include -ffixed-line-length-72 -o CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\sgbcon.f.obj -c CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\sgbcon.f-pp.f
error: loc("D:\\bld\\openblas_1711274852957\\work\\lapack-netlib\\SRC\\sgbcon.f":206:7): operation with block successors must terminate its parent block

error: verification of lowering to FIR failed

Looking for the error message, the only open issue I've found is #61281, but that issue explicitly says "This case is OK in OpenMP". There's also #74348 (which got fixed in 18.1) and #72792 (where it's unclear when/what was fixed).

despite the title of the PR, the error here is for the case with USE_OPENMP=0, i.e. no OpenMP; with OpenMP I still have to fix stuff around OpenMP_Fortran ↩

The text was updated successfully, but these errors were encountered:

llvmbot · 2024-03-25T04:24:41Z

@llvm/issue-subscribers-flang-ir

Author: None (h-vetinari)

I had been under the impression that flang had already been able to compile BLAS/LAPACK and OpenBLAS successfully (c.f. https://github.com//issues/64750, https://github.com//issues/67675, https://github.com//issues/70458).

However, while trying¹ to use flang 18.1.2 to compile the latest OpenBLAS 0.3.26 (aside from from backporting a small fix due to flang 18 being stricter on unknown flags), things fail pretty early with what looks like a parsing problem...

[2005/19090] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\sgbcon.f.obj
FAILED: CMakeFiles/LAPACK_OVERRIDES.dir/lapack-netlib/SRC/sgbcon.f.obj 
%BUILD_PREFIX%\Library\bin\flang.exe -I%SRC_DIR%\lapack-netlib\SRC -I%SRC_DIR%\lapack-netlib\LAPACKE\include -ffixed-line-length-72 -o CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\sgbcon.f.obj -c CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\sgbcon.f-pp.f
error: loc("D:\\bld\\openblas_1711274852957\\work\\lapack-netlib\\SRC\\sgbcon.f":206:7): operation with block successors must terminate its parent block

error: verification of lowering to FIR failed

Looking for the error message, the only open issue I've found is #61281, but that issue explicitly says "This case is OK in OpenMP". There's also #74348 (which got fixed in 18.1) and #72792 (where it's unclear when/what was fixed).

despite the title of the PR, the error here is for the case with USE_OPENMP=0, i.e. no OpenMP; with OpenMP I still have to fix stuff around OpenMP_Fortran ↩

h-vetinari · 2024-04-10T09:18:36Z

Hm, this might somehow be related to #86459?

h-vetinari · 2024-06-28T01:30:01Z

While building OpenBLAS with flang built from main still fails, the good news is that this particular failure seems to have been resolved. Now we're failing at:

[...]
[3643/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\stplqt.f.obj
[3644/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\stplqt2.f.obj
[3645/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\stpmlqt.f.obj
[3646/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_2stage.f.obj
[3647/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F.obj
FAILED: CMakeFiles/LAPACK_OVERRIDES.dir/lapack-netlib/SRC/ssytrd_sb2st.F.obj 
%BUILD_PREFIX%\Library\bin\flang.exe -I%SRC_DIR%\lapack-netlib\SRC -I%SRC_DIR%\lapack-netlib\LAPACKE\include -fopenmp -fopenmp -ffixed-line-length-72 -o CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F.obj -c CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F-pp.f
error: Semantic errors in CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F-pp.f
D:\\bld\\openblas_1719536014536\\work\\lapack-netlib\\SRC\\ssytrd_sb2st.F:237:11: error: Cannot read module file for module 'omp_lib': Source file 'omp_lib.mod' was not found
        use omp_lib
            ^^^^^^^

At first glance, this looks like a problem in OpenBLAS, thus I opened: OpenMathLib/OpenBLAS#4768

h-vetinari · 2024-06-28T06:08:27Z

OK, so the missing omp_lib module is apparently flang's responsibility after all.

CC @banach-space @kiranchandramohan

h-vetinari · 2024-06-28T10:05:11Z

OK, so the non-openmp build actually passed (even though it generated logs so big that I cannot seem to download them, presuambly from warning spam). So the question reduces to OpenBLAS on windows with openmp enabled.

PS. ~500MB of logs, ~5.3 million lines

tblah · 2024-06-28T11:13:38Z

How are you building flang and openmp? I wonder if #90888 could be related.

h-vetinari · 2024-06-28T11:24:56Z

How are you building flang and openmp?

Everything is built stand-alone but from a consistent version (or commit, in this case). I'm using indentation to indicate dependency:

libllvm, llvm-tools, lit
- openmp
- mlir
- clang, clangxx, libclang, etc.
  - compiler-rt
    - flang (also depends on mlir & openmp)

I wonder if #90888 could be related.

That definitely sounds plausible! I could test that patch on top of our openmp builds and see if it changes anything, if that helps.

h-vetinari · 2024-06-28T12:57:16Z

Looking a bit closer, it could just be that we need to set -DLIBOMP_FORTRAN_MODULES=ON? 🤔

h-vetinari · 2024-06-29T21:40:54Z

So I managed to build omp_lib.mod and have it be used by the openblas build, so that's nice. Currently failing at the linking stage, but I think that's just a path question. Will report back once this is figured out.

h-vetinari · 2024-07-08T10:15:04Z

I'm happy to report that (using a small fix to explicitly link OpenMP::OpenMP_C), a ~2 week old flang 19 (as of edf5782, to be precise) is able to build OpenBLAS also on windows. 🥳

There's some issues with the OpenMP configuration for the Fortran bits not correctly being picked up by CMake's find_package(OpenMP), but that's out of scope here (though follow the link for an explanation, if you're interested). There are also some persistent test failures when run on hardware that has AVX512 instructions, but we'll raise a separate issue for that.

Leaving this open for a little while longer in case there are comments, but otherwise this can be closed now. :)

github-actions bot added the flang Flang issues not falling into any other category label Mar 25, 2024

EugeneZelenko added flang:ir and removed flang Flang issues not falling into any other category labels Mar 25, 2024

h-vetinari changed the title ~~[flang] OpenBLAS 0.3.26 not buildable with flang 18~~ [flang] OpenBLAS 0.3.26 not buildable on windows with flang 18 Mar 25, 2024

h-vetinari mentioned this issue Apr 10, 2024

flang fails to lower to FIR on empty module contains #86459

Closed

h-vetinari mentioned this issue Jun 28, 2024

Support building with flang on windows OpenMathLib/OpenBLAS#4768

Open

h-vetinari changed the title ~~[flang] OpenBLAS 0.3.26 not buildable on windows with flang 18~~ [flang] OpenBLAS 0.3.27 not buildable on windows with flang 19 Jun 28, 2024

h-vetinari changed the title ~~[flang] OpenBLAS 0.3.27 not buildable on windows with flang 19~~ [flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 19 Jun 28, 2024

h-vetinari changed the title ~~[flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 19~~ [flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 18 Jul 8, 2024

h-vetinari closed this as completed Jul 8, 2024

EugeneZelenko added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Jul 8, 2024

This was referenced Jul 8, 2024

add openmp on windows conda-forge/openblas-feedstock#115

Merged

Set -DLIBOMP_FORTRAN_MODULES=ON on windows conda-forge/openmp-feedstock#134

Merged

h-vetinari mentioned this issue Jul 19, 2024

Relevant changes from flang 19 cycle conda-forge/flang-feedstock#59

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 18 #86463

[flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 18 #86463

h-vetinari commented Mar 25, 2024 •

edited

Loading

llvmbot commented Mar 25, 2024

h-vetinari commented Apr 10, 2024

h-vetinari commented Jun 28, 2024 •

edited

Loading

h-vetinari commented Jun 28, 2024

h-vetinari commented Jun 28, 2024 •

edited

Loading

tblah commented Jun 28, 2024

h-vetinari commented Jun 28, 2024

h-vetinari commented Jun 28, 2024

h-vetinari commented Jun 29, 2024

h-vetinari commented Jul 8, 2024 •

edited

Loading

[flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 18 #86463

[flang] OpenBLAS 0.3.27 (with openmp) not buildable on windows with flang 18 #86463

Comments

h-vetinari commented Mar 25, 2024 • edited Loading

Footnotes

llvmbot commented Mar 25, 2024

Footnotes

h-vetinari commented Apr 10, 2024

h-vetinari commented Jun 28, 2024 • edited Loading

h-vetinari commented Jun 28, 2024

h-vetinari commented Jun 28, 2024 • edited Loading

tblah commented Jun 28, 2024

h-vetinari commented Jun 28, 2024

h-vetinari commented Jun 28, 2024

h-vetinari commented Jun 29, 2024

h-vetinari commented Jul 8, 2024 • edited Loading

h-vetinari commented Mar 25, 2024 •

edited

Loading

h-vetinari commented Jun 28, 2024 •

edited

Loading

h-vetinari commented Jun 28, 2024 •

edited

Loading

h-vetinari commented Jul 8, 2024 •

edited

Loading