Skip to content

backport 20e212197a5d84f02da14b567d43ae16d46fc643 to the release/14.x branch #54547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tstellar opened this issue Mar 25, 2022 · 8 comments
Closed

backport 20e212197a5d84f02da14b567d43ae16d46fc643 to the release/14.x branch #54547

tstellar opened this issue Mar 25, 2022 · 8 comments
Assignees
@tstellar
Labels
llvm:core obsolete Issues with old (unsupported) versions of LLVM release:backport release:reviewed
Milestone
LLVM 14.0.5 Release

Comments

@tstellar
Copy link
Collaborator

I think 20e2121 will likely fix https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317 and get the windows tests green again.

/cherry-pick 20e2121
@tstellar tstellar added this to the LLVM 14.0.1 Release milestone Mar 25, 2022
@tstellar tstellar moved this to Needs Triage in LLVM Release Status Mar 25, 2022
@tstellar tstellar moved this from Needs Triage to Needs Pull Request in LLVM Release Status Mar 25, 2022
@tstellar
Copy link
Collaborator Author

@RKSimon What do you think about backporting this? 20e2121

@llvmbot
Copy link
Member

llvmbot commented Mar 25, 2022

/branch llvmbot/llvm-project/issue54547

@llvmbot llvmbot mentioned this issue Mar 25, 2022
Open
@llvmbot
Copy link
Member

llvmbot commented Mar 25, 2022

/pull-request llvmbot#133

@tstellar tstellar moved this from Needs Pull Request to Needs Review in LLVM Release Status Apr 6, 2022
@RKSimon
Copy link
Collaborator

RKSimon commented Apr 6, 2022

Sorry - I missed this notification for some reason.

LGTM

@tstellar tstellar moved this from Needs Review to Needs Merge in LLVM Release Status Apr 7, 2022
@RKSimon RKSimon assigned tstellar and unassigned RKSimon Apr 7, 2022
@daira daira mentioned this issue Apr 13, 2022
Closed
@tstellar
Copy link
Collaborator Author

This didn't actually fix the bug, like I thought it would, so I'm going hold off on backporting this one.

@tstellar tstellar moved this from Needs Merge to Needs Fix in LLVM Release Status May 19, 2022
@tstellar
Copy link
Collaborator Author

tstellar commented Jul 14, 2022 •
edited
Loading

This didn't actually fix the bug, like I thought it would, so I'm going hold off on backporting this one.

It looks like this change is actually a no-op, because ErrorHandling.h in the release/14.x branch has:

llvm-project/llvm/include/llvm/Support/ErrorHandling.h

Lines 133 to 140 in f28c006

#ifndef NDEBUG
#define llvm_unreachable(msg) \
::llvm::llvm_unreachable_internal(msg, __FILE__, __LINE__)
#elif defined(LLVM_BUILTIN_UNREACHABLE)
#define llvm_unreachable(msg) LLVM_BUILTIN_UNREACHABLE
#else
#define llvm_unreachable(msg) ::llvm::llvm_unreachable_internal()
#endif

It also looks like a no-op in the main branch too.

@ldionne
Copy link
Member

ldionne commented Feb 13, 2023

Is this still relevant? It seems like we can probably close it at this point.

@ldionne
Copy link
Member

ldionne commented Mar 30, 2023

Closing since this doesn't seem relevant anymore.

@ldionne ldionne closed this as completed Mar 30, 2023
@EugeneZelenko EugeneZelenko added the obsolete Issues with old (unsupported) versions of LLVM label Mar 30, 2023
@EugeneZelenko EugeneZelenko closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstellar tstellar

Labels
llvm:core obsolete Issues with old (unsupported) versions of LLVM release:backport release:reviewed
Projects
LLVM Release Status
Status: Needs Fix
Milestone
LLVM 14.0.5 Release
Development

No branches or pull requests
5 participants
@tstellar @ldionne @RKSimon @EugeneZelenko @llvmbot