Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Add RasterizerOrderedStructuredBuffer definition to HLSLExternalSemaSource #112776

Closed
Tracked by #88
hekota opened this issue Oct 17, 2024 · 1 comment · Fixed by #113648
Closed
Tracked by #88

[HLSL] Add RasterizerOrderedStructuredBuffer definition to HLSLExternalSemaSource #112776

hekota opened this issue Oct 17, 2024 · 1 comment · Fixed by #113648
Assignees
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support

Comments

@hekota
Copy link
Member

hekota commented Oct 17, 2024

Add RasterizerOrderedStructuredBuffer definition to HLSLExternalSemaSource.

The RasterizerOrderedStructuredBuffer is very similiar to RWStructuredBuffer but with ROV guarantees. The resource handle will need an extra attribute is_rov.

https://learn.microsoft.com/en-us/windows/win32/direct3d12/rasterizer-order-views

Refer to Proposal for mapping resource attributes for the attribute mapping.

@EugeneZelenko EugeneZelenko added HLSL HLSL Language Support and removed new issue labels Oct 17, 2024
@hekota hekota self-assigned this Oct 19, 2024
hekota added a commit to hekota/llvm-project that referenced this issue Oct 25, 2024
…alSemaSource

Adds RasterizerOrderedStructuredBuffer definition to HLSLExternalSemaSource. Adds separate tests for the AST shape and element types. Adds constructor/handle.fromBinding and subscript test cases to shared test file for structured buffers.
Additional methods will be added later.

Fixes llvm#112776
hekota added a commit that referenced this issue Nov 6, 2024
…alSemaSource (#113648)

Adds `RasterizerOrderedStructuredBuffer` definition to
HLSLExternalSemaSource. Adds separate tests for the AST shape and
element types. Adds constructor/handle.fromBinding and subscript test
cases to shared test file for structured buffers. Additional methods
will be added later.

Fixes #112776
@EugeneZelenko EugeneZelenko added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Nov 6, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Nov 6, 2024

@llvm/issue-subscribers-clang-frontend

Author: Helena Kotas (hekota)

Add `RasterizerOrderedStructuredBuffer` definition to HLSLExternalSemaSource.

The RasterizerOrderedStructuredBuffer is very similiar to RWStructuredBuffer but with ROV guarantees. The resource handle will need an extra attribute is_rov.

https://learn.microsoft.com/en-us/windows/win32/direct3d12/rasterizer-order-views

Refer to Proposal for mapping resource attributes for the attribute mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support
Projects
Status: Closed
3 participants