Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data layout modeling for CIR types #710

Open
Lancern opened this issue Jul 1, 2024 · 2 comments
Open

Data layout modeling for CIR types #710

Lancern opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Lancern
Copy link
Member

Lancern commented Jul 1, 2024

The data layout of some types are target-specific. For example, the size of a pointer could be 4 or 8 depending on the target. However, the current DataLayoutTypeInterface implementation for all CIR types only return a fixed data layout regardless of the target.

The data layout subsystem of MLIR allows customization of data layouts of types within a specific region. The module op and each region can be attached with data layout properties, typically in the form of data layout specifications, that affect the layout of the types within them. We can leverage this mechanism to make the CIR types aware of the target when computing data layout, by attaching the module op with data layout information computed for the target.

@Lancern Lancern self-assigned this Jul 17, 2024
@Lancern Lancern added the enhancement New feature or request label Jul 17, 2024
@bcardosolopes
Copy link
Member

@Lancern are you currently working on this one? @sitio-couto might be able to take it

@Lancern
Copy link
Member Author

Lancern commented Sep 11, 2024

@bcardosolopes No I have not started working on this. @sitio-couto Feel free to take it!

@Lancern Lancern removed their assignment Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants