Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] memory parsing crashes on unexpected order of "fields" #7580

Open
dtzSiFive opened this issue Sep 3, 2024 · 0 comments
Open

[FIRRTL] memory parsing crashes on unexpected order of "fields" #7580

dtzSiFive opened this issue Sep 3, 2024 · 0 comments
Labels
FIRRTL Involving the `firrtl` dialect

Comments

@dtzSiFive
Copy link
Contributor

Consider:

FIRRTL version 4.0.0

circuit Foo:
  public module Foo:
    mem memory:
      depth => 8
      reader => r
      read-latency => 0
      write-latency => 1
      read-under-write => undefined
      data-type => UInt<8>

Which presently crashes. Moving data-type to the first (above depth => 8), and this works. In the current code is must occur before a port (e.g., reader).

If not supported, this should be rejected / checked.

@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

No branches or pull requests

1 participant