Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] layer-enable attribute verifier allows module as layer symbol #7448

Open
dtzSiFive opened this issue Aug 6, 2024 · 0 comments
Open

[FIRRTL] layer-enable attribute verifier allows module as layer symbol #7448

dtzSiFive opened this issue Aug 6, 2024 · 0 comments
Labels
bug Something isn't working FIRRTL Involving the `firrtl` dialect

Comments

@dtzSiFive
Copy link
Contributor

This input should be rejected (cc #7447):

FIRRTL version 4.0.0

circuit EL:
  extmodule X enablelayer EL :
  public module EL enablelayer EL :
    inst e of X
@dtzSiFive dtzSiFive added bug Something isn't working FIRRTL Involving the `firrtl` dialect labels Aug 6, 2024
dtzSiFive added a commit to dtzSiFive/circt that referenced this issue Aug 26, 2024
@dtzSiFive
[FIRRTL] Verify enabled layers of module, extmodule.
ed9082c 
* Verify specified symbols resolve for extmodule
  (cc llvm#7447)
* Verify specified symbols resolve to LayerOp's
* Verify public modules don't enable circuit-disabled layers.
  (SpecializeLayers will delete if so)

Fixes llvm#7448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtzSiFive