Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drill downs don't work? #10

Open
fraserharris opened this issue Feb 18, 2018 · 2 comments · May be fixed by #11
Open

Drill downs don't work? #10

fraserharris opened this issue Feb 18, 2018 · 2 comments · May be fixed by #11

Comments

@fraserharris
Copy link

I think there are two problems with the drill downs in master_basic_stats.view.lkml, eg: https://github.com/llooker/google_adwords/blob/dev-dillon-morrison-ycx9/master_basic_stats.view.lkml#L337

  1. Missing trailing ,'s in all of the if / else logic.
    Eg: campaign.campaign_name{% endif %}master_stats.total_impressions renders to: campaign.campaign_namemaster_stats.total_impressions, which is an invalid field name.

  2. The url escaped vis=... logic doesn't work? When I click through, I get a link with vis=undefined.
    Eg: vis=%7B%22type%22%3A%22table%22%2C%22show_view_names%22%false%2C%22show_row_numbers%22%3Atrue%2C%22truncate_column_names%22%3Afalse%2C%22hide_totals%22%3Afalse%2C%22hide_row_totals%22%3Afalse%2C%22table_theme%22%3A%22editable%22%2C%22limit_displayed_rows%22%3Afalse%2C%22enable_conditional_formatting%22%3Afalse%2C%22conditional_formatting_include_totals%22%3Afalse%2C%22conditional_formatting_include_nulls%22%3Afalse%7D

@fraserharris
Copy link
Author

fraserharris commented Feb 18, 2018

@gtli7 did you figure out a solution for 2?

@fraserharris
Copy link
Author

fraserharris commented Feb 18, 2018

Huh - when I use Javascript's unescape on the escaped vis data, I get this. Note that the 34th character, ú, looks like a bug:

{"type":"table","show_view_names"úlse,"show_row_numbers":true,"truncate_column_names":false,"hide_totals":false,"hide_row_totals":false,"table_theme":"editable","limit_displayed_rows":false,"enable_conditional_formatting":false,"conditional_formatting_include_totals":false,"conditional_formatting_include_nulls":false}

@fraserharris fraserharris linked a pull request Feb 18, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant