Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page connection won’t be saved #180

Open
MatzeKitt opened this issue Mar 27, 2022 · 1 comment
Open

Page connection won’t be saved #180

MatzeKitt opened this issue Mar 27, 2022 · 1 comment

Comments

@MatzeKitt
Copy link

MatzeKitt commented Mar 27, 2022

Describe the bug
The settings to connect two pages of different blocks don’t work for me. The submit button on the meta box does nothing and if I save the page and reload, the settings of MSLS are reset, unfortunately.

There’s nothing in the console, no error in the network tab and no log in the debug.log.

It seems to be the same issue as in #134. I can reproduce it locally and remote on production.

To Reproduce
Steps to reproduce the behavior:

  1. Select a connected page in a different language
  2. Update the page to save changes
  3. Reload the editor

Expected behaviour
The settings are saved.

Screenshots

Bildschirmaufnahme.2022-03-27.um.15.49.15.mp4

Environment (please complete the following information):

  • OS: macOS
  • Browser: Safari/Chrome
  • PHP Version: 7.4
  • Plugin Version: 2.4.12
@MatzeKitt
Copy link
Author

After a little further trial and error I noticed that the plugin doesn’t like it if there are multiple sites with the same language.

For me, I have two different sites in German and want to make them available in English, too. But in the same multisite. I now use the filter msls_blog_collection_construct to get only the relevant other site by its URL. This seem to be working. But I would love to see proper support for such a variation in the plugin itself. Or at least an error message. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant