Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: SD3 support #3140

Open
1 task done
Szakbal2001 opened this issue Jun 12, 2024 · 7 comments
Open
1 task done

[Feature Request]: SD3 support #3140

Szakbal2001 opened this issue Jun 12, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Szakbal2001
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

Generating image with the new SD3 model

Proposed workflow

Work as usual

Additional information

No response

@Szakbal2001 Szakbal2001 added enhancement New feature or request triage This needs an (initial) review labels Jun 12, 2024
@Haapavuo
Copy link

Haapavuo commented Jun 12, 2024

Definitely a must have!

https://huggingface.co/stabilityai/stable-diffusion-3-medium

@UXVirtual
Copy link

From some initial tests it seems like SD3 can follow detailed instructions in prompts a lot closer than in SDXL, especially around adding specific colors to items in the scene (e.g. pieces of clothing). This could work well with Fooocus styles, given that there aren't many Loras available for SD3 yet.

@mashb1t
Copy link
Collaborator

mashb1t commented Jun 13, 2024

Please find more information about SD3 support in:

@UXVirtual already hinted to some difficulties: SD3 uses a completely different pipeline (mainly encoders, sampling preparation and conditioning), so it's comparable to adding SD 1.5 support with some additional steps, which isn't done quickly and needs patching of ldm_patched first (started in mentioned PR).

As mentioned in #2336 (reply in thread) i'm currently working on another feature.

Feel free to support in solving the issues with the PR, your help is welcome. @lllyasviel same for you :)

@mashb1t mashb1t removed triage This needs an (initial) review labels Jun 13, 2024
@ptits
Copy link

ptits commented Jun 15, 2024

SD3 works in Ruined Fooocus

Check some results
runew0lf#145 (comment)

@IPv6
Copy link

IPv6 commented Jun 17, 2024

RuniedFooocus have an option to directly use comfyUI behind the scenes, without throughout deep integration with other features. Cool, but... it`s not a Fooocus way, imho

@mashb1t
Copy link
Collaborator

mashb1t commented Jun 17, 2024

@IPv6 yes correct, there are various overrides/optimizations/extensions for ComfyUI classes and functions Fooocus uses.

@blckbx
Copy link

blckbx commented Jun 29, 2024

SD3 works in Ruined Fooocus

Check some results runew0lf#145 (comment)

Can confirm the observations. Not impressed with SD3. Been playing around with SD3 on StableSwarm for a while. Image quality is good and rich in details. Human anatomy is awful, a big step back imho. I'll stick to SDXL unless there are trained models that fix the shortcomings. Not speaking of the licensing issues and censorship you can read about on civitai etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants