From 4779cb3d1a1f898d68d42ce0ba2ab8a5bdc00b90 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 15 Aug 2023 16:05:13 -0700 Subject: [PATCH] [Tests] skip some tests that have broken ordering in certain node/eslint combinations --- tests/lib/rules/jsx-equals-spacing.js | 17 +++++++++-------- tests/lib/rules/no-invalid-html-attribute.js | 5 +++-- tests/lib/rules/no-typos.js | 2 +- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/tests/lib/rules/jsx-equals-spacing.js b/tests/lib/rules/jsx-equals-spacing.js index ec3fec93d0..63e6967012 100644 --- a/tests/lib/rules/jsx-equals-spacing.js +++ b/tests/lib/rules/jsx-equals-spacing.js @@ -10,6 +10,7 @@ // ------------------------------------------------------------------------------ const RuleTester = require('eslint').RuleTester; +const semver = require('semver'); const rule = require('../../../lib/rules/jsx-equals-spacing'); const parsers = require('../../helpers/parsers'); @@ -86,8 +87,8 @@ ruleTester.run('jsx-equals-spacing', rule, { }, ]), - invalid: parsers.all([ - { + invalid: parsers.all([].concat( + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', output: '', errors: [ @@ -95,7 +96,7 @@ ruleTester.run('jsx-equals-spacing', rule, { { messageId: 'noSpaceAfter', type: 'JSXAttribute' }, ], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', output: '', options: ['never'], @@ -116,7 +117,7 @@ ruleTester.run('jsx-equals-spacing', rule, { options: ['never'], errors: [{ messageId: 'noSpaceAfter', type: 'JSXAttribute' }], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', output: '', options: ['never'], @@ -126,7 +127,7 @@ ruleTester.run('jsx-equals-spacing', rule, { { messageId: 'noSpaceAfter', type: 'JSXAttribute' }, ], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', output: '', options: ['always'], @@ -147,7 +148,7 @@ ruleTester.run('jsx-equals-spacing', rule, { options: ['always'], errors: [{ messageId: 'needSpaceBefore', type: 'JSXAttribute' }], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', output: '', options: ['always'], @@ -156,6 +157,6 @@ ruleTester.run('jsx-equals-spacing', rule, { { messageId: 'needSpaceAfter', type: 'JSXAttribute' }, { messageId: 'needSpaceAfter', type: 'JSXAttribute' }, ], - }, - ]), + } + )), }); diff --git a/tests/lib/rules/no-invalid-html-attribute.js b/tests/lib/rules/no-invalid-html-attribute.js index 3c3aace4a9..7b5c43a1df 100644 --- a/tests/lib/rules/no-invalid-html-attribute.js +++ b/tests/lib/rules/no-invalid-html-attribute.js @@ -10,6 +10,7 @@ // ------------------------------------------------------------------------------ const RuleTester = require('eslint').RuleTester; +const semver = require('semver'); const rule = require('../../../lib/rules/no-invalid-html-attribute'); const parsers = require('../../helpers/parsers'); @@ -713,7 +714,7 @@ ruleTester.run('no-invalid-html-attribute', rule, { }, ], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', errors: [ { @@ -957,7 +958,7 @@ ruleTester.run('no-invalid-html-attribute', rule, { }, ], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: '', errors: [ { diff --git a/tests/lib/rules/no-typos.js b/tests/lib/rules/no-typos.js index 6342563128..76a2696d23 100644 --- a/tests/lib/rules/no-typos.js +++ b/tests/lib/rules/no-typos.js @@ -1873,7 +1873,7 @@ ruleTester.run('no-typos', rule, { }, ], }, - { + semver.satisfies(process.versions.node, '^8 || ^9') ? [] : { code: ` class Hello extends React.Component { GetDerivedStateFromProps() { }