Skip to content

Make a new release and release it on PyPI #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jabaerchen opened this issue Nov 6, 2022 · 4 comments
Closed

Make a new release and release it on PyPI #175

jabaerchen opened this issue Nov 6, 2022 · 4 comments

Comments

@jabaerchen
Copy link

I quite often use this library in my python projects. Thanks for Contributing this lib 😄!

The last release to PyPI is from 2020 and since then there were some changes I could really use in my projects.

Is it possible for you to create a new version and deploy it to PyPI?

BR
Jan

@ljean
Copy link
Owner

ljean commented Dec 1, 2022

Hello, Thanks for using modbus-tk.

Yes I will. :-) Sorry for this.

There is one issue that may be need attention for this next release : #174

Do you have an opinion about which versions of pyserial to be used?

Best
luc

@jabaerchen
Copy link
Author

jabaerchen commented Dec 22, 2022

Hi Iuc,

sorry for the long delay :|

I am not sure what is the purpose of #174.

I never had problems with pyserial.
So if nothing requires it I would keep the version like it is.

The lib itself did not change since two years and is still with version 3.5.

I check the changelog of pyserial.
I looks good to me.
There should be no API breaking changes.

If you have an idea/plan how to improve the versions I am happy to help here.

BR
Jan

@ljean
Copy link
Owner

ljean commented Feb 10, 2023

OK. I will keep pyserial as it is.

Thank you for your feedback.

I have one issue in progress #172, that I tried to fix with https://github.com/ljean/modbus-tk/tree/bug_172

I will make a new version once this is fixed.
Best

@ljean
Copy link
Owner

ljean commented Feb 13, 2023

1.1.3 has been released

@ljean ljean closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants