You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Outside of this PR I think it would be a good idea to do a refactor to move as much selection logic (i.e. last session tracking, segment in flight tracking, etc.) into MinLSSelector in selection.go to keep that logic encapsulated in a single place. This felt like a hefty change though so I opted not to do that refactor in this PR.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I think encapsulating as much selection logic into selectors in selection.go would reduce code management in broadcast.go and allow us to just call selectors to get the next O to use without the caller needing to be exposed to how the selector is determining which O to return.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
See the following comment from #2666
Describe the solution you'd like
A clear and concise description of what you want to happen.
I think encapsulating as much selection logic into selectors in selection.go would reduce code management in broadcast.go and allow us to just call selectors to get the next O to use without the caller needing to be exposed to how the selector is determining which O to return.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: