From eb7a7553236eb00c65e586bf90a7bbd581867719 Mon Sep 17 00:00:00 2001 From: livecodepanos Date: Thu, 17 Oct 2019 15:30:57 +0300 Subject: [PATCH] [22205] Ensure the check for IDE stacks is accurate This patch ensures that user stacks with names similar to the leaf name of IDE library stacks (e.g. "drawing", "diff" etc) are no longer treated as IDE stacks. The check if the stack name is among the lines of revInternal__ListLoadedLibraries() was removed, as all the stacks included in this list have either their _ideoverride set to true, or begin with "rev". The only exception to this is tsNetLibURL, so for this reason its _ideoverride property is set when this stack is loaded (i.e. in revInternal__LoadIfLibrary) --- Toolset/libraries/revcommonlibrary.livecodescript | 2 -- Toolset/libraries/revinitialisationlibrary.livecodescript | 1 + notes/bugfix-22205.md | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 notes/bugfix-22205.md diff --git a/Toolset/libraries/revcommonlibrary.livecodescript b/Toolset/libraries/revcommonlibrary.livecodescript index 7ac4f0dc42..3618627edd 100644 --- a/Toolset/libraries/revcommonlibrary.livecodescript +++ b/Toolset/libraries/revcommonlibrary.livecodescript @@ -464,8 +464,6 @@ function revStackNameIsIDEStack pStackName return true else if pStackName begins with "com.livecode." then return true - else if pStackName is among the lines of revInternal__ListLoadedLibraries() then - return true else return pStackName begins with "rev" end if diff --git a/Toolset/libraries/revinitialisationlibrary.livecodescript b/Toolset/libraries/revinitialisationlibrary.livecodescript index ee68643138..6423542beb 100644 --- a/Toolset/libraries/revinitialisationlibrary.livecodescript +++ b/Toolset/libraries/revinitialisationlibrary.livecodescript @@ -68,6 +68,7 @@ command revInternal__LoadIfLibrary pLibrary else throw "not a library" end if + set the _ideoverride of stack pLibrary to true send tMsg to stack pLibrary local tStackName put the name of stack pLibrary into tStackName diff --git a/notes/bugfix-22205.md b/notes/bugfix-22205.md new file mode 100644 index 0000000000..9aa35715f0 --- /dev/null +++ b/notes/bugfix-22205.md @@ -0,0 +1 @@ +# Ensure user stacks that have library names, e.g. "drawing", "diff" etc are not treated as IDE stacks