Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many warnings with PHP > 8.0 versions #1118

Open
bittailor opened this issue Feb 7, 2024 · 2 comments
Open

Many warnings with PHP > 8.0 versions #1118

bittailor opened this issue Feb 7, 2024 · 2 comments

Comments

@bittailor
Copy link

I upgraded my WordPress Server from PHP 7.4. to PHP 8.2, as PHP 7.4 is now End of life for more than a year and WordPress Release 6.4 recommends PHP 8.1 or 8.2.

Now the Live Composer plugin (Release 1.5.33) generates a lot of Undefined array key warnings like

PHP Warning:  Undefined array key "main_location" in /var/www/html/wp-content/plugins/live-composer-page-builder/modules/blog/module.php on line 3759
[php:notice] PHP Stack trace:
[php:notice] 1. {main}() ...
... 

That spam the logs and hides possible other issues.

Are you planning to support to PHP >= 8.1 without warnings?
Are you interested in a PR that tries to fix/remove those Undefined array key warnings?

@jamesdlow
Copy link
Contributor

jamesdlow commented Jul 14, 2024

I've fixed some common ones in the include/ directory in this pull request here: #1139

Will work on fixing some of the ones in individual modules after this pull request is merged.

@jamesdlow
Copy link
Contributor

Here's a few of the errors I commonly see on common modules:

PHP message: PHP Warning: Undefined array key "link_nofollow" in /wp-content/plugins/live-composer-page-builder/modules/social/module.php on line 103
PHP message: PHP Warning: Undefined array key "link_nofollow" in /wp-content/plugins/live-composer-page-builder/modules/image/module.php on line 1076
PHP message: PHP Warning: Undefined array key "image_alt" in /wp-content/plugins/live-composer-page-builder/modules/image/module.php on line 1078
PHP message: PHP Warning: Undefined array key "link_nofollow" in /wp-content/plugins/live-composer-page-builder/modules/image/module.php on line 1076
PHP message: PHP Warning: Undefined array key "image_alt" in /wp-content/plugins/live-composer-page-builder/modules/image/module.php on line 1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants