Refactor how payment instruments are updated #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on current_member_header for exposing payment instruments, create API's that fetchs the instrument(s) when the appropriate page is loaded. Otherwise current_member_header could possibly hold large payment instrument data. - Remove dependency of `add_current_member_header` (payment instruments can contain large data) - Only fetch instruments when we're in the `Funding` page - Only fetch instrument when we are adding funds to it - Test api changes - Test frontend checkout card adding
DeeTheDev
added
backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 444 444
Lines 20154 20174 +20
=======================================
+ Hits 19738 19758 +20
Misses 416 416 ☔ View full report in Codecov by Sentry. |
|
As discussed during pairing, this isn't a suitable solution for the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Instead of relying on current_member_header for exposing payment instruments, create API's that fetchs the instrument(s) when the appropriate page is loaded. Otherwise current_member_header could possibly hold large payment instrument data.
add_current_member_header(payment instruments can contain large data)Fundingpage