From f56b2f8699e80411d87792ee704fca59162e0dd1 Mon Sep 17 00:00:00 2001 From: Chris Howarth Date: Sat, 31 Aug 2019 10:19:07 +0100 Subject: [PATCH 01/25] Update gitignore --- .gitignore | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.gitignore b/.gitignore index bc31345e..95e80e4b 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +/GPUCache /Cache /Data /Errors @@ -7,6 +8,29 @@ /Utils /WTF +# Ignore addons +/Interface/Addons + +# But don't ignore NeavUI addons +# This allows you to install any other addons you want to and they wont be tracked by git +# Any addon you want to be a part of NeavUI and be tracked by git, add to this list +!/Interface/Addons/!BeautyCase +!/Interface/Addons/!Colorz +!/Interface/Addons/evl_RaidStatus +!/Interface/Addons/nBuff +!/Interface/Addons/nCore +!/Interface/Addons/nMainbar +!/Interface/Addons/nMinimap +!/Interface/Addons/nPlates +!/Interface/Addons/nPower +!/Interface/Addons/nTooltip +!/Interface/Addons/oUF +!/Interface/Addons/oUF_Neav +!/Interface/Addons/oUF_NeavRaid + +.curseclient +.flavor.info + .build.info .patch.result From 968c2ea653e11dc1d834082f0a5f484632375df1 Mon Sep 17 00:00:00 2001 From: Chris Howarth Date: Sat, 31 Aug 2019 10:21:29 +0100 Subject: [PATCH 02/25] Update gitmodules --- .gitmodules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index e2e766b2..9e40acb6 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,6 +1,6 @@ [submodule "Interface/AddOns/oUF"] path = Interface/AddOns/oUF - url = git@github.com:oUF-wow/oUF.git + url = https://github.com/oUF-wow/oUF.git [submodule "Interface/AddOns/nPlates"] path = Interface/AddOns/nPlates - url = git@github.com:Grimsbain/nPlates.git + url = https://github.com/Grimsbain/nPlates.git From 3e50f463a029d9550fd9b55d9a530c090f3bd696 Mon Sep 17 00:00:00 2001 From: Chris Howarth Date: Sat, 31 Aug 2019 10:29:25 +0100 Subject: [PATCH 03/25] Update !BeautyCase toc version --- Interface/AddOns/!Beautycase/!Beautycase.toc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Interface/AddOns/!Beautycase/!Beautycase.toc b/Interface/AddOns/!Beautycase/!Beautycase.toc index d87e5d2d..ae778494 100644 --- a/Interface/AddOns/!Beautycase/!Beautycase.toc +++ b/Interface/AddOns/!Beautycase/!Beautycase.toc @@ -1,4 +1,4 @@ -## Interface: 80200 +## Interface: 11302 ## Title: !Beautycase core.lua From a3cfb8f3c6f13266d85b5b1c0a35b4748c3b07c3 Mon Sep 17 00:00:00 2001 From: Chris Howarth Date: Sat, 31 Aug 2019 10:43:29 +0100 Subject: [PATCH 04/25] Update !Colorz to work with Classic Updated toc version and removed code relying on GetFriendshipReputation as it is not available in Classic --- Interface/AddOns/!Colorz/!Colorz.lua | 25 +++++++------------------ Interface/AddOns/!Colorz/!Colorz.toc | 2 +- 2 files changed, 8 insertions(+), 19 deletions(-) diff --git a/Interface/AddOns/!Colorz/!Colorz.lua b/Interface/AddOns/!Colorz/!Colorz.lua index d87cbe24..9075c040 100644 --- a/Interface/AddOns/!Colorz/!Colorz.lua +++ b/Interface/AddOns/!Colorz/!Colorz.lua @@ -44,33 +44,22 @@ hooksecurefunc("ReputationFrame_Update", function(showLFGPulse) if factionIndex <= numFactions then local name, description, standingID = GetFactionInfo(factionIndex) - local colorIndex = standingID - local friendID = GetFriendshipReputation(factionID) - - if friendID ~= nil then - colorIndex = 5 -- always color friendships green - end - local color = CUSTOM_FACTION_BAR_COLORS[colorIndex] factionBar:SetStatusBarColor(color.r, color.g, color.b) end end end) -hooksecurefunc(ReputationBarMixin, "Update", function(self) - local name, reaction, minBar, maxBar, value, factionID = GetWatchedFactionInfo(); - local colorIndex = reaction; - local friendshipID = GetFriendshipReputation(factionID); +-- 'ReputationBarMixin' is not available in Classic +-- hooksecurefunc(ReputationBarMixin, "Update", function(self) +-- local name, reaction, minBar, maxBar, value, factionID = GetWatchedFactionInfo(); +-- local colorIndex = reaction; - if friendshipID then - colorIndex = 5; -- always color friendships green - end - - local color = CUSTOM_FACTION_BAR_COLORS[colorIndex]; - self:SetBarColor(color.r, color.g, color.b, 1); -end) +-- local color = CUSTOM_FACTION_BAR_COLORS[colorIndex]; +-- self:SetBarColor(color.r, color.g, color.b, 1); +-- end) -- Override the default GameTooltip_UnitColor function. diff --git a/Interface/AddOns/!Colorz/!Colorz.toc b/Interface/AddOns/!Colorz/!Colorz.toc index 3185b8ce..257e8513 100644 --- a/Interface/AddOns/!Colorz/!Colorz.toc +++ b/Interface/AddOns/!Colorz/!Colorz.toc @@ -1,4 +1,4 @@ -## Interface: 80200 +## Interface: 11302 ## Title: !Colorz ## Notes: Custom colors From 14523a34a4283dc79486b205130fc785d5419f5f Mon Sep 17 00:00:00 2001 From: Chris Howarth Date: Sat, 31 Aug 2019 19:55:02 +0100 Subject: [PATCH 05/25] Update nCore to work with Classic --- Interface/AddOns/nCore/modules/coords.lua | 8 +++-- Interface/AddOns/nCore/modules/durability.lua | 12 +++++-- .../AddOns/nCore/modules/objectivetracker.lua | 3 ++ .../AddOns/nCore/modules/questtracker.lua | 11 +++--- Interface/AddOns/nCore/modules/vignette.lua | 2 ++ Interface/AddOns/nCore/nCore.toc | 2 +- Interface/AddOns/nCore/nCore.xml | 7 +++- Interface/AddOns/nCore/options.lua | 34 +++++++++---------- 8 files changed, 52 insertions(+), 27 deletions(-) diff --git a/Interface/AddOns/nCore/modules/coords.lua b/Interface/AddOns/nCore/modules/coords.lua index 81e3913f..da2e22b0 100644 --- a/Interface/AddOns/nCore/modules/coords.lua +++ b/Interface/AddOns/nCore/modules/coords.lua @@ -4,7 +4,11 @@ function nCore:MapCoords() local unpack = unpack -- Temp fix until Blizzard removed the ! icon from the global string. - local _, MOUSE_LABEL = strsplit("1", MOUSE_LABEL, 2) + -- Extended this to support Classic as 'strsplit' won't work on MOUSE_LABEL as it doesn't have the ! icon + local _, mouseLabel = strsplit("1", MOUSE_LABEL, 2) + if ( mouseLabel == nil ) then + mouseLabel = MOUSE_LABEL + end local cfg = { location = {"BOTTOMLEFT", WorldMapFrame, "BOTTOMLEFT", 10, 0}, @@ -56,7 +60,7 @@ function nCore:MapCoords() if cx then if cx >= 0 and cy >= 0 and cx <= 1 and cy <= 1 then - self.Mouse.Text:SetFormattedText("%s: %.1f x %.1f", MOUSE_LABEL, cx * 100, cy * 100) + self.Mouse.Text:SetFormattedText("%s: %.1f x %.1f", mouseLabel, cx * 100, cy * 100) else self.Mouse.Text:SetText("") end diff --git a/Interface/AddOns/nCore/modules/durability.lua b/Interface/AddOns/nCore/modules/durability.lua index bf615517..fb46194e 100644 --- a/Interface/AddOns/nCore/modules/durability.lua +++ b/Interface/AddOns/nCore/modules/durability.lua @@ -30,8 +30,16 @@ function nCore:Durability() local charString = CharacterLevelText charString:SetFont(STANDARD_TEXT_FONT, 14) - local tab = CreateFrame("Button", "PaperDollFrameDurabilityTab", PaperDollSidebarTab1, "CharacterFrameTabButtonTemplate") - tab:SetPoint("TOP", PaperDollFrame, "BOTTOM", 170, 2) + -- For retail use PaperDollSidebarTab1, Classic use PaperDollItemsFrame + local tab = nil + if PaperDollSidebarTab1 then + tab = CreateFrame('Button', 'PaperDollFrameDurabilityTab', PaperDollSidebarTab1, 'CharacterFrameTabButtonTemplate') + tab:SetPoint('TOP', PaperDollFrame, 'BOTTOM', 170, 2) + else + tab = CreateFrame('Button', 'PaperDollFrameDurabilityTab', PaperDollItemsFrame, 'CharacterFrameTabButtonTemplate') + tab:SetPoint('TOP', PaperDollFrame, 'BOTTOM', 103, 78) + end + tab:Disable() tab:EnableMouse(false) tab:SetFrameStrata("BACKGROUND") diff --git a/Interface/AddOns/nCore/modules/objectivetracker.lua b/Interface/AddOns/nCore/modules/objectivetracker.lua index 01fe783b..04259e2d 100644 --- a/Interface/AddOns/nCore/modules/objectivetracker.lua +++ b/Interface/AddOns/nCore/modules/objectivetracker.lua @@ -2,6 +2,9 @@ local _, nCore = ... local L = nCore.L function nCore:ObjectiveTracker() + -- Classic: 'ObjectiveTrackerFrame' isn't available? Have commented out the config option for now + if ( not ObjectiveTrackerFrame ) then return end + if ( not nCoreDB.ObjectiveTracker ) then return end local objectiveTrackerFrame = _G["ObjectiveTrackerFrame"] diff --git a/Interface/AddOns/nCore/modules/questtracker.lua b/Interface/AddOns/nCore/modules/questtracker.lua index 4a8517ee..a1525883 100644 --- a/Interface/AddOns/nCore/modules/questtracker.lua +++ b/Interface/AddOns/nCore/modules/questtracker.lua @@ -3,8 +3,11 @@ local _, nCore = ... function nCore:QuestTracker() local function UpdateQuestText() local _, numQuests = GetNumQuestLogEntries() - WorldMapFrameTitleText:SetFormattedText("%s - %d/%s", MAP_AND_QUEST_LOG, numQuests, MAX_QUESTS) - WorldMapFrameTitleText:Show() + -- Classic TODO: 'WorldMapFrameTitleText' doesn't appear to exist, is there an alternative? + -- Have commented out the config option for now + + -- WorldMapFrameTitleText:SetFormattedText("%s - %d/%s", MAP_AND_QUEST_LOG, numQuests, MAX_QUESTS) + -- WorldMapFrameTitleText:Show() end UpdateQuestText() @@ -21,8 +24,8 @@ function nCore:QuestTracker() if nCoreDB.QuestTracker then UpdateQuestText() else - WorldMapFrameTitleText:SetText(MAP_AND_QUEST_LOG) - WorldMapFrameTitleText:Show() + -- WorldMapFrameTitleText:SetText(MAP_AND_QUEST_LOG) + -- WorldMapFrameTitleText:Show() end end) end diff --git a/Interface/AddOns/nCore/modules/vignette.lua b/Interface/AddOns/nCore/modules/vignette.lua index 4a53f307..bfb27958 100644 --- a/Interface/AddOns/nCore/modules/vignette.lua +++ b/Interface/AddOns/nCore/modules/vignette.lua @@ -3,6 +3,8 @@ local _, nCore = ... -- Forked from rVignette by zork - 2014 function nCore:VignetteAlert() + -- Classic: 'C_VignetteInfo' isn't available, have commented out the config option for now + if (not C_VignetteInfo) then return end local addon = CreateFrame("Frame") diff --git a/Interface/AddOns/nCore/nCore.toc b/Interface/AddOns/nCore/nCore.toc index d3aa0999..62940a90 100644 --- a/Interface/AddOns/nCore/nCore.toc +++ b/Interface/AddOns/nCore/nCore.toc @@ -1,4 +1,4 @@ -## Interface: 80200 +## Interface: 11320 ## Title: |cffCC3333 n|rCore ## OptionalDeps: !Beautycase, Recount, Omen, DBM, PitBull4, Skada, TinyDPS ## SavedVariables: nCoreDB diff --git a/Interface/AddOns/nCore/nCore.xml b/Interface/AddOns/nCore/nCore.xml index 301ab34b..0fcfdde1 100644 --- a/Interface/AddOns/nCore/nCore.xml +++ b/Interface/AddOns/nCore/nCore.xml @@ -3,7 +3,12 @@