feat: added subprocess test client #3655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
|
Tests are failing because the redis fixture does not seem to work correctly. Tbh, added that as a best guess, so would need some help with fixing this. Alternatively, I just replace the test with a regular "does it connect and return the right thing" kind of test and ditch the SSE testing. No idea why doc generation is failing. |
cc: @litestar-org/maintainers thought? |
cofin
force-pushed
the
feat/subprocess-test-client
branch
from
cd6443e
to
469a572
Compare
provinzkraut
force-pushed
the
feat/subprocess-test-client
branch
from
469a572
to
7366207
Compare
provinzkraut
approved these changes
Sep 15, 2024
provinzkraut
force-pushed
the
feat/subprocess-test-client
branch
from
e4bc209
to
baee5d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces new helper functions to create sync and async test clients that can be used to test SSE endpoints with infinite generators as outlined in #3654 and https://github.com/orgs/litestar-org/discussions/3547.
The litestar cli is run in a subprocess to start a web app instance with a random port. The helper function then sets up a basic sync or async client.
The test code and doc example show how this can be used to test an SSE endpoint with an infinite generator.
Overview:
subprocess_async_clientandsubprocess_sync_clientsubprocess_async_clientCloses
Closes #3654