You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Suggestion: Remove trailing commas in arguments of functions / arguments lists.
Reason: This feature is only available in ES8/ES2017 and when compiling for a lower version it throws various hard to see errors. The default target in the tsconfig for Angular 8 is es6 so these errors come up when using this library with TypeScript in Angular (and I'm sure others).
ToDo: Remove trailing commas here:
Base.js line 39
canvasRenderer.js many - drop it into https://jshint.com to find
fontMetrics.js > line 114
svgRenderer many - use jsHint or something similar to find
Util.js line 143
TextRenderer line 102, 125, 144-155
LiterallyCanvas.js many - use JSHint
RenderSnapshotToImage.js line 53, 73
RenderSnapshotToSVG.js line 36, 43
Shapes.js many - use JSHint
Pan.js line 31
Polygon.js JSHint
SelectShape.js line 112, 123
Text.js JSHint
Opinion: There's nothing really gained by having them (?) but a lot lost by including them as far as compatibility when used with default settings in popular frameworks.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Suggestion: Remove trailing commas in arguments of functions / arguments lists.
Reason: This feature is only available in ES8/ES2017 and when compiling for a lower version it throws various hard to see errors. The default target in the tsconfig for Angular 8 is es6 so these errors come up when using this library with TypeScript in Angular (and I'm sure others).
ToDo: Remove trailing commas here:
Base.js line 39
canvasRenderer.js many - drop it into https://jshint.com to find
fontMetrics.js > line 114
svgRenderer many - use jsHint or something similar to find
Util.js line 143
TextRenderer line 102, 125, 144-155
LiterallyCanvas.js many - use JSHint
RenderSnapshotToImage.js line 53, 73
RenderSnapshotToSVG.js line 36, 43
Shapes.js many - use JSHint
Pan.js line 31
Polygon.js JSHint
SelectShape.js line 112, 123
Text.js JSHint
Opinion: There's nothing really gained by having them (?) but a lot lost by including them as far as compatibility when used with default settings in popular frameworks.
The text was updated successfully, but these errors were encountered: