Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement id_graph_stats getter #2175

Open
Kailai-Wang opened this issue Oct 5, 2023 · 0 comments
Open

Implement id_graph_stats getter #2175

Kailai-Wang opened this issue Oct 5, 2023 · 0 comments
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days tech-debt A technical debt which needs to be payback.

Comments

@Kailai-Wang
Copy link
Collaborator

Context

Some tech-debt from old TODO:

// TODO: we need to re-think it
// currently, _who is ignored meaning it's actually not a "trusted" getter.
// In fact, in the production no one should have access to the concrete identities
// but maybe it makes sense to get some statistic information
// Disabled until it's resolved
// Disabled the test `lit-id-graph-stats` too
TrustedGetter::id_graph_stats(_who) => None,

We need to differentiate between dev and prod implementations.

In production we only want some generic statistics, e.g. how many unique IDGraphs were created, the distribution of identities in each IDGraph etc.

In dev we could additionally list all IDGraphs.

It should not be a trusted getter (as it's not specific to an account which needs authentication).


✔️ Please set appropriate labels and assignees if applicable.

@Kailai-Wang Kailai-Wang added I2-medium should be completed within 10 working days D1-feature A new feature, a piece of functionality that needs to be developed tech-debt A technical debt which needs to be payback. labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days tech-debt A technical debt which needs to be payback.
Projects
None yet
Development

No branches or pull requests

1 participant