Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log correct row number with header consistency check #89

Open
jeffkole opened this issue Mar 27, 2024 · 1 comment
Open

Log correct row number with header consistency check #89

jeffkole opened this issue Mar 27, 2024 · 1 comment
Assignees

Comments

@jeffkole
Copy link
Collaborator

In Phase#check_headers_consistent since the context.current_row is not updated when the warnings are logged, all of the warnings are associated with the last row number, even though the full row (along with its row number) are passed into the add_warning function call.

check_headers_consistent should log which row the error occurred on.

@jeffkole
Copy link
Collaborator Author

Need to revalidate this issue, as it may have been fixed with recent changes.

@jeffkole jeffkole self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant