Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search placeholder text. #208

Open
allanchau opened this issue May 2, 2018 · 0 comments
Open

Improve search placeholder text. #208

allanchau opened this issue May 2, 2018 · 0 comments

Comments

@allanchau
Copy link
Contributor

Expected behaviour

We should be able to customise the search placeholder text.

Actual behaviour

The text is set to the model name.

Notes

I think list.search should be updated to be an object that accepts fields and placeholder properties. The placeholder text would override the default if provided.

The default placeholder text should also be updated to list the labels of the search fields instead of the model name since the model title is already next to the search bar? eg Search ${label}, ${label2}, and ${label3}. This would prevent any confusion on what the user can search for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant